PRESUBMIT: Improve PyLint check and add GN format check.

Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).

Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.

Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py

TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.

R=henrika@webrtc.org, phoglund@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/50069004

Cr-Commit-Position: refs/heads/master@{#9274}

tools/PRESUBMIT.py

@@ -8,13 +8,13 @@
 
 def _LicenseHeader(input_api):
   """Returns the license header regexp."""
-  # Accept any year number from 2011 to the current year
+  # Accept any year number from 2003 to the current year
   current_year = int(input_api.time.strftime('%Y'))
-  allowed_years = (str(s) for s in reversed(xrange(2011, current_year + 1)))
+  allowed_years = (str(s) for s in reversed(xrange(2003, current_year + 1)))
   years_re = '(' + '|'.join(allowed_years) + ')'
   license_header = (
-      r'.*? Copyright \(c\) %(year)s The WebRTC project authors\. '
-        r'All Rights Reserved\.\n'
+      r'.*? Copyright( \(c\))? %(year)s The WebRTC [Pp]roject [Aa]uthors\. '
+        r'All [Rr]ights [Rr]eserved\.\n'
       r'.*?\n'
       r'.*? Use of this source code is governed by a BSD-style license\n'
       r'.*? that can be found in the LICENSE file in the root of the source\n'
@@ -30,14 +30,6 @@ def _LicenseHeader(input_api):
 def _CommonChecks(input_api, output_api):
   """Checks common to both upload and commit."""
   results = []
-  results.extend(input_api.canned_checks.CheckLongLines(
-      input_api, output_api, maxlen=80))
-  results.extend(input_api.canned_checks.CheckChangeHasNoTabs(
-      input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
-      input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeTodoHasOwner(
-      input_api, output_api))
   results.extend(input_api.canned_checks.CheckLicense(
       input_api, output_api, _LicenseHeader(input_api)))
   return results
@@ -50,13 +42,4 @@ def CheckChangeOnUpload(input_api, output_api):
 def CheckChangeOnCommit(input_api, output_api):
   results = []
   results.extend(_CommonChecks(input_api, output_api))
-  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeWasUploaded(
-      input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeHasDescription(
-      input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeHasBugField(
-      input_api, output_api))
-  results.extend(input_api.canned_checks.CheckChangeHasTestField(
-      input_api, output_api))
   return results

tools/autoroller/cl_description.py

@@ -24,6 +24,7 @@ CHROMIUM_COMMIT_TEMPLATE = CHROMIUM_SRC_URL + '/+/%s'
 CHROMIUM_FILE_TEMPLATE = CHROMIUM_SRC_URL + '/+/%s/%s'
 
 GIT_NUMBER_RE = re.compile('^Cr-Commit-Position: .*#([0-9]+).*$')
+CLANG_REVISION_RE = re.compile(r'^CLANG_REVISION=(\d+)$')
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 CHECKOUT_ROOT_DIR = os.path.join(SCRIPT_DIR, os.pardir, os.pardir)
 sys.path.append(CHECKOUT_ROOT_DIR)
@@ -156,8 +157,11 @@ def calculate_changed_deps(current_deps, new_deps):
 
 def calculate_changed_clang(new_cr_rev):
   def get_clang_rev(lines):
-    key = 'CLANG_REVISION='
-    return filter(lambda x: x.startswith(key), lines)[0][len(key):].strip()
+    for line in lines:
+      match = CLANG_REVISION_RE.match(line)
+      if match:
+        return match.group(1)
+    return None
 
   chromium_src_path = os.path.join(CHECKOUT_ROOT_DIR, 'chromium', 'src',
                                    CLANG_UPDATE_SCRIPT_LOCAL_PATH)

tools/cpu/cpu_mon.py

@@ -9,7 +9,6 @@
 # be found in the AUTHORS file in the root of the source tree.
 
 
-import argparse
 import psutil
 import sys
 

tools/network_emulator/network_emulator.py

@@ -186,4 +186,4 @@ def _run_ipfw_command(command, fail_msg=None):
   if process.returncode != 0:
     raise NetworkEmulatorError(fail_msg, cmd_string, process.returncode, output,
                                error)
-  return output.strip()
+  return output.strip()

tools/perf/perf_utils.py

@@ -1,6 +1,12 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
+#!/usr/bin/env python
+#
+# Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS.  All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
 
 # Copied from /src/chrome/test/pyautolib/pyauto_utils.py in Chromium.
 
@@ -28,4 +34,4 @@ def PrintPerfResult(graph_name, series_name, data_point, units,
   print '%sRESULT %s: %s= %s %s' % (
       waterfall_indicator, graph_name, series_name,
       str(data_point).replace(' ', ''), units)
-  sys.stdout.flush()
+  sys.stdout.flush()

tools/python_charts/webrtc/__init__.py

@@ -5,4 +5,4 @@
 #  that can be found in the LICENSE file in the root of the source
 #  tree. An additional intellectual property rights grant can be found
 #  in the file PATENTS.  All contributing project authors may
-#  be found in the AUTHORS file in the root of the source tree.
+#  be found in the AUTHORS file in the root of the source tree.

tools/python_charts/webrtc/data_helper.py

@@ -89,7 +89,7 @@ class DataHelper(object):
     # We're going to have one dictionary per row.
     # Create that and copy frame_number values from the first data set
     for source_row in self.data_list[0]:
-      row_dict = { 'frame_number': source_row['frame_number'] }
+      row_dict = {'frame_number': source_row['frame_number']}
       result_data_table.append(row_dict)
 
     # Pick target field data points from the all data tables

tools/python_charts/webrtc/data_helper_test.py

@@ -18,7 +18,7 @@ class Test(unittest.TestCase):
                          {'frame_number': 1, 'ssim': 0.55, 'psnr': 30.55}]
     self.frame_data_1 = [{'frame_number': 0, 'ssim': 0.6, 'psnr': 30.6},
                          {'frame_number': 0, 'ssim': 0.66, 'psnr': 30.66}]
-    self.all_data = [ self.frame_data_0, self.frame_data_1 ]
+    self.all_data = [self.frame_data_0, self.frame_data_1]
 
     # Test with frame_number column in a non-first position sice we need to
     # support reordering that to be able to use the gviz_api as we want.

tools/python_charts/webrtc/main.py

@@ -37,7 +37,7 @@ def main():
   page_template_filename = '../templates/chart_page_template.html'
   # The data files must be located in the project tree for app engine being
   # able to access them.
-  data_filenames = [ '../data/vp8_sw.py', '../data/vp8_hw.py' ]
+  data_filenames = ['../data/vp8_sw.py', '../data/vp8_hw.py']
   # Will contain info/error messages to be displayed on the resulting page.
   messages = []
   # Load the page HTML template.