generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Enable -Wformat-security warning and cleanup GYP.

Browse Source 
Enable the -Wformat-security and -Wformat warnings for talk/.

Remove *.def and *.h.pump files from webrtc/base/base.gyp since they're not supported by some tools.

BUG=4242
R=henrika@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/49969004

Cr-Commit-Position: refs/heads/master@{#9191}
This commit is contained in:
Henrik Kjellander 2015-05-15 09:10:30 +02:00
parent 39f2b0c870
commit 4cd6940e49
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
talk/build/common.gypi
View File

@ -88,11 +88,17 @@
'LINUX', 'LINUX',
'WEBRTC_LINUX', 'WEBRTC_LINUX',
], ],
# Remove Chromium's disabling of the -Wformat warning.
'cflags!': [
'-Wno-format',
],
'conditions': [ 'conditions': [
['clang==1', { ['clang==1', {
'cflags': [ 'cflags': [
'-Wall', '-Wall',
'-Wextra', '-Wextra',
'-Wformat',
'-Wformat-security',
'-Wimplicit-fallthrough', '-Wimplicit-fallthrough',
'-Wmissing-braces', '-Wmissing-braces',
'-Wreorder', '-Wreorder',

9
webrtc/base/base.gyp
View File

@ -127,9 +127,7 @@
'base64.h', 'base64.h',
'basicdefs.h', 'basicdefs.h',
'bind.h', 'bind.h',
'bind.h.pump',
'callback.h', 'callback.h',
'callback.h.pump',
'common.cc', 'common.cc',
'common.h', 'common.h',
'cpumonitor.cc', 'cpumonitor.cc',
@ -176,9 +174,7 @@
'json.cc', 'json.cc',
'json.h', 'json.h',
'latebindingsymboltable.cc', 'latebindingsymboltable.cc',
'latebindingsymboltable.cc.def',
'latebindingsymboltable.h', 'latebindingsymboltable.h',
'latebindingsymboltable.h.def',
'libdbusglibsymboltable.cc', 'libdbusglibsymboltable.cc',
'libdbusglibsymboltable.h', 'libdbusglibsymboltable.h',
'linux.cc', 'linux.cc',
@ -382,9 +378,7 @@
'bandwidthsmoother.cc', 'bandwidthsmoother.cc',
'bandwidthsmoother.h', 'bandwidthsmoother.h',
'bind.h', 'bind.h',
'bind.h.pump',
'callback.h', 'callback.h',
'callback.h.pump',
'constructormagic.h', 'constructormagic.h',
'dbus.cc', 'dbus.cc',
'dbus.h', 'dbus.h',
@ -394,15 +388,12 @@
'filelock.h', 'filelock.h',
'fileutils_mock.h', 'fileutils_mock.h',
'genericslot.h', 'genericslot.h',
'genericslot.h.pump',
'httpserver.cc', 'httpserver.cc',
'httpserver.h', 'httpserver.h',
'json.cc', 'json.cc',
'json.h', 'json.h',
'latebindingsymboltable.cc', 'latebindingsymboltable.cc',
'latebindingsymboltable.cc.def',
'latebindingsymboltable.h', 'latebindingsymboltable.h',
'latebindingsymboltable.h.def',
'libdbusglibsymboltable.cc', 'libdbusglibsymboltable.cc',
'libdbusglibsymboltable.h', 'libdbusglibsymboltable.h',
'linuxfdwalk.c', 'linuxfdwalk.c',