Mark all virtual overrides in the hierarchy of AudioPacketizationCallback,
RTPStream, and NetEq as such. Also mark all other virtual overrides in the same files. This will make further changes to these classes safer by ensuring that the compile breaks if the base class changes and not all overrides are fixed. This also deletes ACMTest.cc, which existed solely to define ~ACMTest(), which was marked pure virtual in the header. (Pure virtual destructors still need a definition.) Because there is another pure virtual method in this class, the class is already abstract, so there's no benefit to making the desturctor pure. Making it non-pure allows removing the separate source file. BUG=none TEST=none R=henrik.lundin@webrtc.org, niklas.enbom@webrtc.org Review URL: https://webrtc-codereview.appspot.com/29389004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7144 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
@@ -329,7 +329,6 @@
|
||||
'<@(audio_coding_defines)',
|
||||
],
|
||||
'sources': [
|
||||
'audio_coding/main/test/ACMTest.cc',
|
||||
'audio_coding/main/test/APITest.cc',
|
||||
'audio_coding/main/test/Channel.cc',
|
||||
'audio_coding/main/test/dual_stream_unittest.cc',
|
||||
|
||||
Reference in New Issue
Block a user