generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Temporarily disabling some more audio processing tests.

Browse Source 
R=andrew@webrtc.org, bjornv@webrtc.org, xians@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/7019005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@5380 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
aluebs@webrtc.org 2014-01-14 08:57:22 +00:00
parent eb31b45aaf
commit 4371d4650a
2 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
View File

@ -22,7 +22,9 @@ class AgcConfigTest : public AfterStreamingFixture {
webrtc::AgcConfig default_agc_config_; webrtc::AgcConfig default_agc_config_;
}; };
TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) { // TODO(aluebs): Re-enable tests in agc_config_test and audio_processing_test
// when possible. Bug: issue 2784.
TEST_F(AgcConfigTest, DISABLED_HasCorrectDefaultConfiguration) {
webrtc::AgcConfig agc_config; webrtc::AgcConfig agc_config;
EXPECT_EQ(0, voe_apm_->GetAgcConfig(agc_config)); EXPECT_EQ(0, voe_apm_->GetAgcConfig(agc_config));
@ -33,7 +35,7 @@ TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) {
EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable); EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable);
} }
TEST_F(AgcConfigTest, DealsWithInvalidParameters) { TEST_F(AgcConfigTest, DISABLED_DealsWithInvalidParameters) {
webrtc::AgcConfig agc_config = default_agc_config_; webrtc::AgcConfig agc_config = default_agc_config_;
agc_config.digitalCompressionGaindB = 91; agc_config.digitalCompressionGaindB = 91;
EXPECT_EQ(-1, voe_apm_->SetAgcConfig(agc_config)) << "Should not be able " EXPECT_EQ(-1, voe_apm_->SetAgcConfig(agc_config)) << "Should not be able "
@ -47,7 +49,7 @@ TEST_F(AgcConfigTest, DealsWithInvalidParameters) {
EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError()); EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError());
} }
TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) { TEST_F(AgcConfigTest, DISABLED_CanGetAndSetAgcStatus) {
webrtc::AgcConfig agc_config; webrtc::AgcConfig agc_config;
agc_config.digitalCompressionGaindB = 17; agc_config.digitalCompressionGaindB = 17;
agc_config.targetLeveldBOv = 11; agc_config.targetLeveldBOv = 11;
@ -65,7 +67,7 @@ TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) {
actual_config.targetLeveldBOv); actual_config.targetLeveldBOv);
} }
TEST_F(AgcConfigTest, HasCorrectDefaultRxConfiguration) { TEST_F(AgcConfigTest, DISABLED_HasCorrectDefaultRxConfiguration) {
webrtc::AgcConfig agc_config; webrtc::AgcConfig agc_config;
EXPECT_EQ(0, voe_apm_->GetRxAgcConfig(channel_, agc_config)); EXPECT_EQ(0, voe_apm_->GetRxAgcConfig(channel_, agc_config));
@ -76,7 +78,7 @@ TEST_F(AgcConfigTest, HasCorrectDefaultRxConfiguration) {
EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable); EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable);
} }
TEST_F(AgcConfigTest, DealsWithInvalidRxParameters) { TEST_F(AgcConfigTest, DISABLED_DealsWithInvalidRxParameters) {
webrtc::AgcConfig agc_config = default_agc_config_; webrtc::AgcConfig agc_config = default_agc_config_;
agc_config.digitalCompressionGaindB = 91; agc_config.digitalCompressionGaindB = 91;
EXPECT_EQ(-1, voe_apm_->SetRxAgcConfig(channel_, agc_config)) << EXPECT_EQ(-1, voe_apm_->SetRxAgcConfig(channel_, agc_config)) <<
@ -90,7 +92,7 @@ TEST_F(AgcConfigTest, DealsWithInvalidRxParameters) {
EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError()); EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError());
} }
TEST_F(AgcConfigTest, CanGetAndSetRxAgcStatus) { TEST_F(AgcConfigTest, DISABLED_CanGetAndSetRxAgcStatus) {
webrtc::AgcConfig agc_config; webrtc::AgcConfig agc_config;
agc_config.digitalCompressionGaindB = 17; agc_config.digitalCompressionGaindB = 17;
agc_config.targetLeveldBOv = 11; agc_config.targetLeveldBOv = 11;

10
webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc
View File

@ -140,7 +140,7 @@ class AudioProcessingTest : public AfterStreamingFixture {
#if !defined(WEBRTC_IOS) && !defined(WEBRTC_ANDROID) #if !defined(WEBRTC_IOS) && !defined(WEBRTC_ANDROID)
TEST_F(AudioProcessingTest, AgcIsOnByDefault) { TEST_F(AudioProcessingTest, DISABLED_AgcIsOnByDefault) {
bool agc_enabled = false; bool agc_enabled = false;
webrtc::AgcModes agc_mode = webrtc::kAgcAdaptiveAnalog; webrtc::AgcModes agc_mode = webrtc::kAgcAdaptiveAnalog;
@ -149,7 +149,7 @@ TEST_F(AudioProcessingTest, AgcIsOnByDefault) {
EXPECT_EQ(webrtc::kAgcAdaptiveAnalog, agc_mode); EXPECT_EQ(webrtc::kAgcAdaptiveAnalog, agc_mode);
} }
TEST_F(AudioProcessingTest, CanEnableAgcWithAllModes) { TEST_F(AudioProcessingTest, DISABLED_CanEnableAgcWithAllModes) {
TryEnablingAgcWithMode(webrtc::kAgcAdaptiveDigital); TryEnablingAgcWithMode(webrtc::kAgcAdaptiveDigital);
TryEnablingAgcWithMode(webrtc::kAgcAdaptiveAnalog); TryEnablingAgcWithMode(webrtc::kAgcAdaptiveAnalog);
TryEnablingAgcWithMode(webrtc::kAgcFixedDigital); TryEnablingAgcWithMode(webrtc::kAgcFixedDigital);
@ -248,7 +248,7 @@ TEST_F(AudioProcessingTest, CanSetAecmMode) {
TryEnablingAecmWithMode(webrtc::kAecmSpeakerphone, false); TryEnablingAecmWithMode(webrtc::kAecmSpeakerphone, false);
} }
TEST_F(AudioProcessingTest, RxAgcShouldBeOffByDefault) { TEST_F(AudioProcessingTest, DISABLED_RxAgcShouldBeOffByDefault) {
bool rx_agc_enabled = true; bool rx_agc_enabled = true;
webrtc::AgcModes agc_mode = webrtc::kAgcDefault; webrtc::AgcModes agc_mode = webrtc::kAgcDefault;
@ -257,12 +257,12 @@ TEST_F(AudioProcessingTest, RxAgcShouldBeOffByDefault) {
EXPECT_EQ(webrtc::kAgcAdaptiveDigital, agc_mode); EXPECT_EQ(webrtc::kAgcAdaptiveDigital, agc_mode);
} }
TEST_F(AudioProcessingTest, CanTurnOnDigitalRxAcg) { TEST_F(AudioProcessingTest, DISABLED_CanTurnOnDigitalRxAcg) {
TryEnablingRxAgcWithMode(webrtc::kAgcAdaptiveDigital); TryEnablingRxAgcWithMode(webrtc::kAgcAdaptiveDigital);
TryEnablingRxAgcWithMode(webrtc::kAgcFixedDigital); TryEnablingRxAgcWithMode(webrtc::kAgcFixedDigital);
} }
TEST_F(AudioProcessingTest, CannotTurnOnAdaptiveAnalogRxAgc) { TEST_F(AudioProcessingTest, DISABLED_CannotTurnOnAdaptiveAnalogRxAgc) {
EXPECT_EQ(-1, voe_apm_->SetRxAgcStatus( EXPECT_EQ(-1, voe_apm_->SetRxAgcStatus(
channel_, true, webrtc::kAgcAdaptiveAnalog)); channel_, true, webrtc::kAgcAdaptiveAnalog));
} }