Removed the WEBRTC_NO_TRACE macro since the style guide wants us to stear clear of macros and this one doesn't seem to have a purpose at this point.
Review URL: http://webrtc-codereview.appspot.com/315006 git-svn-id: http://webrtc.googlecode.com/svn/trunk@1233 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
parent
8da2417c9d
commit
4158c35820
@ -105,10 +105,6 @@
|
|||||||
'defines': [
|
'defines': [
|
||||||
# Changes settings for Chromium build.
|
# Changes settings for Chromium build.
|
||||||
'WEBRTC_CHROMIUM_BUILD',
|
'WEBRTC_CHROMIUM_BUILD',
|
||||||
# This turns off tracing in webrtc to reduce the noise from
|
|
||||||
# the Chrome memory bots. Down the line we will enable WebRTC
|
|
||||||
# tracing for Chromium and remove this.
|
|
||||||
'WEBRTC_NO_TRACE',
|
|
||||||
],
|
],
|
||||||
}],
|
}],
|
||||||
['OS=="linux"', {
|
['OS=="linux"', {
|
||||||
|
@ -18,26 +18,7 @@
|
|||||||
#include "common_types.h"
|
#include "common_types.h"
|
||||||
#include "typedefs.h"
|
#include "typedefs.h"
|
||||||
|
|
||||||
#ifdef WEBRTC_NO_TRACE
|
#define WEBRTC_TRACE Trace::Add
|
||||||
#ifdef WIN32
|
|
||||||
// Use __noop to avoid the C4353 compiler warning on Windows.
|
|
||||||
#define WEBRTC_TRACE __noop()
|
|
||||||
#else
|
|
||||||
// This is a workaround. Ideally we should be able to do
|
|
||||||
// something like:
|
|
||||||
// #define WEBRTC_TRACE(...) ((void)0)
|
|
||||||
// However, we have code that creates variables with the only
|
|
||||||
// intent of tracing out their value. So, if we take the above
|
|
||||||
// approach, then we'll get a compiler error about unused variables. :(
|
|
||||||
inline void WebRtcNoTrace(...) {}
|
|
||||||
#define WEBRTC_TRACE WebRtcNoTrace
|
|
||||||
#endif
|
|
||||||
#else
|
|
||||||
// Ideally we would use _VA_ARGS_ but it's not supported by all compilers
|
|
||||||
// such as VS2003 (it's supported in VS2005). TODO (hellner) why
|
|
||||||
// would this be better than current implementation (not convinced)?
|
|
||||||
#define WEBRTC_TRACE Trace::Add
|
|
||||||
#endif
|
|
||||||
|
|
||||||
namespace webrtc {
|
namespace webrtc {
|
||||||
class Trace
|
class Trace
|
||||||
|
Loading…
Reference in New Issue
Block a user