generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable TestVp8Impl.BaseUnitTest on MSan.

Browse Source 
MemorySanitizer uses generic (non-optimized) libvpx which is not bit
exact. This may be a bug in upstream libvpx, but we're forced to disable
it now as it blocks launching the MSan bot.

R=stefan@webrtc.org
TBR=marpan@webrtc.org
BUG=3904

Review URL: https://webrtc-codereview.appspot.com/24089004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7491 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pbos@webrtc.org 2014-10-22 10:30:30 +00:00
parent 76960d5f74
commit 3f8f5554a0
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
View File

@ -192,7 +192,13 @@ class TestVp8Impl : public ::testing::Test {
VideoCodec codec_inst_; VideoCodec codec_inst_;
}; };
// Disabled on MemorySanitizer as it's breaking on generic libvpx.
// https://code.google.com/p/webrtc/issues/detail?id=3904
#if defined(MEMORY_SANITIZER)
TEST_F(TestVp8Impl, DISABLED_BaseUnitTest) {
#else
TEST_F(TestVp8Impl, DISABLED_ON_ANDROID(BaseUnitTest)) { TEST_F(TestVp8Impl, DISABLED_ON_ANDROID(BaseUnitTest)) {
#endif
// TODO(mikhal): Remove dependency. Move all test code here. // TODO(mikhal): Remove dependency. Move all test code here.
EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, encoder_->Release()); EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, encoder_->Release());
UnitTest unittest; UnitTest unittest;