From 3f11823a1a802d6073c416d32c347e7fb6b236f7 Mon Sep 17 00:00:00 2001 From: "bjornv@webrtc.org" Date: Mon, 16 Mar 2015 14:22:03 +0000 Subject: [PATCH] Disables SW AEC when built-in AEC is enabled As of r7849 the built-in AEC on devicing supporting it is enabled by default. Unfortunately, the SW AEC (AECM) was not disabled, hence running on top of the built-in one. This is not necessary. In fact it reduce double talk performance significantly. BUG=4431 TESTED=manually R=henrika@webrtc.org, mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/49419004 Cr-Commit-Position: refs/heads/master@{#8735} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8735 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/media/webrtc/webrtcvoiceengine.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/talk/media/webrtc/webrtcvoiceengine.cc b/talk/media/webrtc/webrtcvoiceengine.cc index 20c2e50e1..282c0334c 100644 --- a/talk/media/webrtc/webrtcvoiceengine.cc +++ b/talk/media/webrtc/webrtcvoiceengine.cc @@ -824,6 +824,7 @@ bool WebRtcVoiceEngine::ApplyOptions(const AudioOptions& options_in) { // Disable internal software EC if device has its own built-in EC, // i.e., replace the software EC with the built-in EC. options.echo_cancellation.Set(false); + echo_cancellation = false; LOG(LS_INFO) << "Disabling EC since built-in EC will be used instead"; } }