generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't log warning for unexpected STUN binding responses.

Browse Source 
It was too spammy in the log because we have many code paths that check for responses when it's not a problem that it's not an expected response.

R=glaznev@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/47199004

Cr-Commit-Position: refs/heads/master@{#9212}
This commit is contained in:
Peter Thatcher 2015-05-18 15:55:18 -07:00
parent 79b2e06782
commit 3e95d3ef39
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/p2p/base/stunrequest.cc
View File

@ -78,8 +78,8 @@ void StunRequestManager::Clear() {
bool StunRequestManager::CheckResponse(StunMessage* msg) {
RequestMap::iterator iter = requests_.find(msg->transaction_id());
if (iter == requests_.end()) {
LOG(LS_WARNING) << "Ignoring STUN response for unknown request "
<< rtc::hex_encode(msg->transaction_id());
// TODO(pthatcher): Log unknown responses without being too spammy
// in the logs.
return false;
}
@ -111,8 +111,8 @@ bool StunRequestManager::CheckResponse(const char* data, size_t size) {
RequestMap::iterator iter = requests_.find(id);
if (iter == requests_.end()) {
LOG(LS_WARNING) << "Ignoring STUN response for unknown request "
<< rtc::hex_encode(id);
// TODO(pthatcher): Log unknown responses without being too spammy
// in the logs.
return false;
}