From 3c412b24d990b7db329341e0c02792aaf38dd347 Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Mon, 24 Mar 2014 12:36:52 +0000 Subject: [PATCH] Add targetBitrate to VideoCodec struct. To be used by a codec implementation. Could for instance be interpreted as trying to fit as much as possible on one temporal layer and send everything that doesn't fit within target bitrate on another one. Prevents an existing hack where startBitrate is used by a codec implementation to signify target bitrate. This hack forces a reset of bitrate estimation to target bitrate which creates bitrate dips. BUG= R=mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/10479004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5759 4adac7df-926f-26a2-2b94-8c16560cd09d --- webrtc/common_types.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/webrtc/common_types.h b/webrtc/common_types.h index 3a22b949e..b1f1ba05d 100644 --- a/webrtc/common_types.h +++ b/webrtc/common_types.h @@ -643,6 +643,8 @@ struct VideoCodec { unsigned int startBitrate; // kilobits/sec. unsigned int maxBitrate; // kilobits/sec. unsigned int minBitrate; // kilobits/sec. + unsigned int targetBitrate; // kilobits/sec. + unsigned char maxFramerate; VideoCodecUnion codecSpecific; @@ -672,6 +674,7 @@ struct VideoCodecDerived : public VideoCodec { startBitrate == other.startBitrate && maxBitrate == other.maxBitrate && minBitrate == other.minBitrate && + targetBitrate == other.targetBitrate && maxFramerate == other.maxFramerate && qpMax == other.qpMax && numberOfSimulcastStreams == other.numberOfSimulcastStreams &&