From 3a93986fd509fd22e700be2d66a48c5b32c6afc7 Mon Sep 17 00:00:00 2001
From: Thiago Farina <tfarina@chromium.org>
Date: Thu, 9 Apr 2015 15:45:12 +0200
Subject: [PATCH] Exit after printing usage message.

We should not continue the program if the user asked for help.

Tested on Linux with the following command line:

$ out/Debug/frame_analyzer --help

BUG=None
TEST=see above
R=kjellander@webrtc.org, stefan@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/44069004

Patch from Thiago Farina <tfarina@chromium.org>.

Cr-Commit-Position: refs/heads/master@{#8961}
---
 webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc | 1 +
 webrtc/tools/converter/rgba_to_i420_converter.cc             | 1 +
 webrtc/tools/frame_analyzer/frame_analyzer.cc                | 1 +
 webrtc/tools/frame_editing/frame_editing.cc                  | 1 +
 webrtc/tools/psnr_ssim_analyzer/psnr_ssim_analyzer.cc        | 1 +
 5 files changed, 5 insertions(+)

diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
index a116d74bf..8fe78d4b2 100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_sequence_coder.cc
@@ -230,6 +230,7 @@ int main(int argc, char** argv) {
   parser.ProcessFlags();
   if (parser.GetFlag("help") == "true") {
     parser.PrintUsageMessage();
+    exit(EXIT_SUCCESS);
   }
   parser.PrintEnteredFlags();
 
diff --git a/webrtc/tools/converter/rgba_to_i420_converter.cc b/webrtc/tools/converter/rgba_to_i420_converter.cc
index 126a31c7a..6b1056fae 100644
--- a/webrtc/tools/converter/rgba_to_i420_converter.cc
+++ b/webrtc/tools/converter/rgba_to_i420_converter.cc
@@ -61,6 +61,7 @@ int main(int argc, char** argv) {
   parser.ProcessFlags();
   if (parser.GetFlag("help") == "true") {
     parser.PrintUsageMessage();
+    exit(EXIT_SUCCESS);
   }
   parser.PrintEnteredFlags();
 
diff --git a/webrtc/tools/frame_analyzer/frame_analyzer.cc b/webrtc/tools/frame_analyzer/frame_analyzer.cc
index aed956562..802010932 100644
--- a/webrtc/tools/frame_analyzer/frame_analyzer.cc
+++ b/webrtc/tools/frame_analyzer/frame_analyzer.cc
@@ -74,6 +74,7 @@ int main(int argc, char** argv) {
   parser.ProcessFlags();
   if (parser.GetFlag("help") == "true") {
     parser.PrintUsageMessage();
+    exit(EXIT_SUCCESS);
   }
   parser.PrintEnteredFlags();
 
diff --git a/webrtc/tools/frame_editing/frame_editing.cc b/webrtc/tools/frame_editing/frame_editing.cc
index fa234ef8e..015d5d99a 100644
--- a/webrtc/tools/frame_editing/frame_editing.cc
+++ b/webrtc/tools/frame_editing/frame_editing.cc
@@ -77,6 +77,7 @@ int main(int argc, char** argv) {
   parser.ProcessFlags();
   if (parser.GetFlag("help") == "true") {
     parser.PrintUsageMessage();
+    exit(EXIT_SUCCESS);
   }
   parser.PrintEnteredFlags();
 
diff --git a/webrtc/tools/psnr_ssim_analyzer/psnr_ssim_analyzer.cc b/webrtc/tools/psnr_ssim_analyzer/psnr_ssim_analyzer.cc
index 9c9b131a2..3fb468bce 100644
--- a/webrtc/tools/psnr_ssim_analyzer/psnr_ssim_analyzer.cc
+++ b/webrtc/tools/psnr_ssim_analyzer/psnr_ssim_analyzer.cc
@@ -115,6 +115,7 @@ int main(int argc, char** argv) {
   parser.ProcessFlags();
   if (parser.GetFlag("help") == "true") {
     parser.PrintUsageMessage();
+    exit(EXIT_SUCCESS);
   }
   parser.PrintEnteredFlags();