generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Change kEchoCancellation to be 'echoCancellation'.

Browse Source 
This is the second cl in WebRTC for this change and will be landed after Chromium has been updated to use kGooglEchoCancellation where that variant is required. See also the first part: https://codereview.webrtc.org/1179233003

BUG=webrtc:4747
R=andrew@webrtc.org

Review URL: https://codereview.webrtc.org/1185963003

Cr-Commit-Position: refs/heads/master@{#9490}
This commit is contained in:
tommi
2015-06-23 09:50:47 -07:00
committed by Commit bot
parent 747d5f6268
commit 39b31001d2
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
talk/app/webrtc/mediaconstraintsinterface.cc
View File

@@ -47,7 +47,7 @@ const char MediaConstraintsInterface::kMinFrameRate[] = "minFrameRate";
// Audio constraints. // Audio constraints.
const char MediaConstraintsInterface::kEchoCancellation[] = const char MediaConstraintsInterface::kEchoCancellation[] =
"googEchoCancellation"; "echoCancellation";
const char MediaConstraintsInterface::kGoogEchoCancellation[] = const char MediaConstraintsInterface::kGoogEchoCancellation[] =
"googEchoCancellation"; "googEchoCancellation";
const char MediaConstraintsInterface::kExtendedFilterEchoCancellation[] = const char MediaConstraintsInterface::kExtendedFilterEchoCancellation[] =

7
talk/app/webrtc/mediaconstraintsinterface.h
View File

@@ -72,12 +72,9 @@ class MediaConstraintsInterface {
static const char kMinFrameRate[]; // minFrameRate static const char kMinFrameRate[]; // minFrameRate
// Constraint keys used by a local audio source. // Constraint keys used by a local audio source.
static const char kEchoCancellation[]; // echoCancellation
// These keys are google specific. // These keys are google specific.
// TODO(tommi): Change kEchoCancellation to be "echoCancellation" once
// Chrome has been updated to use kGoogEchoCancellation where the 'goog'
// variant is needed.
// See https://code.google.com/p/webrtc/issues/detail?id=4747
static const char kEchoCancellation[]; // googEchoCancellation
static const char kGoogEchoCancellation[]; // googEchoCancellation static const char kGoogEchoCancellation[]; // googEchoCancellation
static const char kExtendedFilterEchoCancellation[]; // googEchoCancellation2 static const char kExtendedFilterEchoCancellation[]; // googEchoCancellation2