generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

PRESUBMIT: Only notify GN changes for GYP files in webrtc/*

Browse Source 
We don't maintain a BUILD.gn file for talk/ since it's a part
of Chromium:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/BUILD.gn
Because of this, it's confusing to get warnings about updating
a GYP file in talk/ from the PRESUBMIT check.

TESTED=Successsfully ran git cl presubmit with this change
applied on top of a CL containing changes in .gyp files.

R=niklas.enbom@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/27189004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7737 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org 2014-11-24 10:05:37 +00:00
parent 8562f23acb
commit 3398a4ac15
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PRESUBMIT.py
View File

@ -128,7 +128,8 @@ def _CheckGypChanges(input_api, output_api):
gyp_files = []
for f in input_api.AffectedSourceFiles(source_file_filter):
gyp_files.append(f)
if f.LocalPath().startswith('webrtc'):
gyp_files.append(f)
result = []
if gyp_files: