generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reduce flakiness of voe_auto_test MixingTest by checking dumped audio size

Browse Source 
BUG=webrtc:2925

TEST=passed_all_trybots
R=andrew@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/18479005

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6193 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
minyue@webrtc.org 2014-05-20 08:33:30 +00:00
parent 1732a591e7
commit 2db9f45038
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
webrtc/voice_engine/test/auto_test/standard/mixing_test.cc
View File

@ -87,6 +87,9 @@ class MixingTest : public AfterInitializationFixture {
EXPECT_EQ(0, voe_file_->StartRecordingPlayout(-1 /* record meeting */,
output_filename_.c_str()));
SleepMs(kTestDurationMs);
while (GetFileDurationMs(output_filename_.c_str()) < kTestDurationMs) {
SleepMs(200);
}
EXPECT_EQ(0, voe_file_->StopRecordingPlayout(-1));
StopLocalStreams(local_streams);
@ -126,7 +129,7 @@ class MixingTest : public AfterInitializationFixture {
// Ensure we've at least recorded half as much file as the duration of the
// test. We have to use a relaxed tolerance here due to filesystem flakiness
// on the bots.
ASSERT_GE((samples_read * 1000.0) / kSampleRateHz, 0.5 * kTestDurationMs);
ASSERT_GE((samples_read * 1000.0) / kSampleRateHz, kTestDurationMs);
// Ensure we read the entire file.
ASSERT_NE(0, feof(output_file));
ASSERT_EQ(0, fclose(output_file));
@ -199,6 +202,17 @@ class MixingTest : public AfterInitializationFixture {
}
}
int GetFileDurationMs(const char* file_name) {
FILE* fid = fopen(file_name, "rb");
EXPECT_FALSE(fid == NULL);
fseek(fid, 0, SEEK_END);
int size = ftell(fid);
EXPECT_NE(-1, size);
fclose(fid);
// Divided by 2 due to 2 bytes/sample.
return size * 1000 / kSampleRateHz / 2;
}
std::string input_filename_;
const std::string output_filename_;
LoopBackTransport* transport_;