generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable WEBRTC_SVNREVISION

Browse Source 
Description:
This CL will temporally define WEBRTC_SVNREVISION as "n/a" because it
could break Chromium if svn is not installed.
The long term solution is a have a script that could deal with it, and
have it support git-svn which is used by most developers.

BUG=496
TEST=build on Linux
Review URL: https://webrtc-codereview.appspot.com/569007

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2187 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
leozwang@webrtc.org 2012-05-07 21:16:33 +00:00
parent fe4cfa7e5e
commit 20a05cd778
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/build/common.gypi
View File

@ -91,9 +91,16 @@
'..','../..', # common_types.h, typedefs.h '..','../..', # common_types.h, typedefs.h
], ],
'defines': [ 'defines': [
# TODO(leozwang): Most of team use git-svn, need to add # TODO(leozwang): Temporally disable it because we cannot assume svn
# git-svn support as well. # is installed by default, it will break Chromium build. The problem
'WEBRTC_SVNREVISION="<!(svnversion -n)"', # could happen on Gentoo which download and build tar ball directly,
# it also could happen when developer downloads Chromium tar ball and
# build inside source tree without svn installed. The solution is to
# have a script to deal with these cases and support git-svn.
# Two similar issues have been filed at
# WebRTC http://code.google.com/p/webrtc/issues/detail?id=496
# Chromium http://code.google.com/p/chromium/issues/detail?id=126452
'WEBRTC_SVNREVISION="n/a"',
], ],
'conditions': [ 'conditions': [
['build_with_chromium==1', { ['build_with_chromium==1', {