generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Initialize restored_packet in nack_rtx_unittest.cc.

Browse Source 
This is to get the DrMemory Full bots to go green, this was previously
suppressed. This fix is likely hiding a real bug that should be
investigated, but it's not a regression from before. The issue should
not be closed before we figure out why this is the case and revert this
"fix".

TBR=stefan@webrtc.org
BUG=3183

Review URL: https://webrtc-codereview.appspot.com/30369004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7169 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
pbos@webrtc.org 2014-09-12 16:16:00 +00:00
parent c3c9015bc6
commit 1fb5d1204b
2 changed files with 4 additions and 57 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
tools/valgrind-webrtc/drmemory/suppressions.txt
View File

@ -858,62 +858,6 @@ name=https://code.google.com/p/webrtc/issues/detail?id=3184 (7)
*!webrtc::MouseCursorMonitorTest_ShapeOnly_Test::TestBody *!webrtc::MouseCursorMonitorTest_ShapeOnly_Test::TestBody
*!testing::internal::HandleSehExceptionsInMethodIfSupported<> *!testing::internal::HandleSehExceptionsInMethodIfSupported<>
UNINITIALIZED READ
name=https://code.google.com/p/webrtc/issues/detail?id=3183 (1)
*!webrtc::RTPReceiverVideo::ReceiveGenericCodec
*!webrtc::RTPReceiverVideo::ParseVideoCodecSpecific
*!webrtc::RTPReceiverVideo::ParseRtpPacket
*!webrtc::RtpReceiverImpl::IncomingRtpPacket
*!RtxLoopBackTransport::SendPacket
*!webrtc::RTPSender::SendPacketToNetwork
*!webrtc::RTPSender::SendToNetwork
*!webrtc::RTPSenderVideo::SendVideoPacket
*!webrtc::RTPSenderVideo::SendGeneric
*!webrtc::RTPSenderVideo::SendVideo
*!webrtc::RTPSender::SendOutgoingData
*!webrtc::ModuleRtpRtcpImpl::SendOutgoingData
*!RtpRtcpRtxNackTest_LongNackList_Test::TestBody
*!testing::internal::HandleSehExceptionsInMethodIfSupported<>
UNINITIALIZED READ
name=name=https://code.google.com/p/webrtc/issues/detail?id=3183 (2)
*!webrtc::RTPReceiverVideo::ReceiveGenericCodec
*!webrtc::RTPReceiverVideo::ParseVideoCodecSpecific
*!webrtc::RTPReceiverVideo::ParseRtpPacket
*!webrtc::RtpReceiverImpl::IncomingRtpPacket
*!RtxLoopBackTransport::SendPacket
*!webrtc::RTPSender::SendPacketToNetwork
*!webrtc::RTPSender::PrepareAndSendPacket
*!webrtc::RTPSender::ReSendPacket
*!webrtc::RTPSender::OnReceivedNACK
*!webrtc::ModuleRtpRtcpImpl::OnReceivedNACK
*!webrtc::RTCPReceiver::TriggerCallbacksFromRTCPPacket
*!webrtc::ModuleRtpRtcpImpl::IncomingRtcpPacket
*!RtxLoopBackTransport::SendRTCPPacket
*!webrtc::RTCPSender::SendToNetwork
*!webrtc::RTCPSender::SendRTCP
*!webrtc::ModuleRtpRtcpImpl::SendNACK
*!RtpRtcpRtxNackTest_LongNackList_Test::TestBody
*!testing::internal::HandleSehExceptionsInMethodIfSupported<>
UNINITIALIZED READ
name=name=https://code.google.com/p/webrtc/issues/detail?id=3183 (3)
*!webrtc::RTPReceiverVideo::ReceiveGenericCodec
*!webrtc::RTPReceiverVideo::ParseVideoCodecSpecific
*!webrtc::RTPReceiverVideo::ParseRtpPacket
*!webrtc::RtpReceiverImpl::IncomingRtpPacket
*!RtxLoopBackTransport::SendPacket
*!webrtc::RTPSender::SendPacketToNetwork
*!webrtc::RTPSender::SendToNetwork
*!webrtc::RTPSenderVideo::SendVideoPacket
*!webrtc::RTPSenderVideo::SendGeneric
*!webrtc::RTPSenderVideo::SendVideo
*!webrtc::RTPSender::SendOutgoingData
*!webrtc::ModuleRtpRtcpImpl::SendOutgoingData
*!RtpRtcpRtxNackTest::RunRtxTest
*!RtpRtcpRtxNackTest_RtxNack_Test::TestBody
*!testing::internal::HandleSehExceptionsInMethodIfSupported<>
UNINITIALIZED READ UNINITIALIZED READ
name=https://code.google.com/p/webrtc/issues/detail?id=3490 (1) name=https://code.google.com/p/webrtc/issues/detail?id=3490 (1)
drmemorylib.dll!replace_memcmp drmemorylib.dll!replace_memcmp

5
webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc
View File

@ -112,7 +112,10 @@ class RtxLoopBackTransport : public webrtc::Transport {
return len; return len;
} }
int packet_length = len; int packet_length = len;
uint8_t restored_packet[1500]; // TODO(pbos): Figure out why this needs to be initialized. Likely this
// is hiding a bug either in test setup or other code.
// https://code.google.com/p/webrtc/issues/detail?id=3183
uint8_t restored_packet[1500] = {0};
uint8_t* restored_packet_ptr = restored_packet; uint8_t* restored_packet_ptr = restored_packet;
RTPHeader header; RTPHeader header;
scoped_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create()); scoped_ptr<RtpHeaderParser> parser(RtpHeaderParser::Create());