From 1f569222b2c2da8b419a0a6d2f08d54db0d174eb Mon Sep 17 00:00:00 2001 From: "pwestin@webrtc.org" Date: Fri, 23 Mar 2012 09:04:16 +0000 Subject: [PATCH] Clean up coverity warnings. Review URL: https://webrtc-codereview.appspot.com/456003 git-svn-id: http://webrtc.googlecode.com/svn/trunk@1928 4adac7df-926f-26a2-2b94-8c16560cd09d --- src/modules/udp_transport/source/udp_transport_impl.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/modules/udp_transport/source/udp_transport_impl.cc b/src/modules/udp_transport/source/udp_transport_impl.cc index b8eb1420b..28ab8926e 100644 --- a/src/modules/udp_transport/source/udp_transport_impl.cc +++ b/src/modules/udp_transport/source/udp_transport_impl.cc @@ -2168,7 +2168,9 @@ void UdpTransportImpl::IncomingRTPFunction(const WebRtc_Word8* rtpPacket, information"); }else { - strncpy(_fromIP, ipAddress, kIpAddressVersion6Length); + // Make sure ipAddress is null terminated. + ipAddress[kIpAddressVersion6Length - 1] = 0; + strncpy(_fromIP, ipAddress, kIpAddressVersion6Length - 1); } // Filter based on port. @@ -2226,7 +2228,9 @@ void UdpTransportImpl::IncomingRTCPFunction(const WebRtc_Word8* rtcpPacket, "UdpTransportImpl::IncomingRTCPFunction - Cannot get sender\ information"); }else { - strncpy(_fromIP, ipAddress, kIpAddressVersion6Length); + // Make sure ipAddress is null terminated. + ipAddress[kIpAddressVersion6Length - 1] = 0; + strncpy(_fromIP, ipAddress, kIpAddressVersion6Length - 1); } // Filter based on port.