generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Remove <(webrtc_root) from source file entries."

Browse Source 
And the follow-up fix in r8198 that was not sufficient.
Reason: breaks Chromium bots runhooks (GYP).

I will have to try some more to make sure I don't
include test code, since include_tests==0 in Chromium.

TBR=andrew@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/37039004

Cr-Commit-Position: refs/heads/master@{#8200}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8200 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
kjellander@webrtc.org
2015-01-29 12:02:01 +00:00
parent a26f511dd2
commit 1ece0cbbec
18 changed files with 115 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
PRESUBMIT.py
View File

@@ -127,7 +127,7 @@ def _CheckNoSourcesAboveGyp(input_api, gyp_files, output_api):
# Disallow referencing source files with paths above the GYP file location.
source_pattern = input_api.re.compile(r'sources.*?\[(.*?)\]',
re.MULTILINE | re.DOTALL)
file_pattern = input_api.re.compile(r"'((\.\./.*?)|(<\(webrtc_root\).*?))'")
file_pattern = input_api.re.compile(r"'(\.\./.*?)'")
violating_gyp_files = set()
violating_source_entries = []
for gyp_file in gyp_files: