From 1ec2b389265f96412a91c991ffb07ef9adc8c288 Mon Sep 17 00:00:00 2001 From: "stefan@webrtc.org" Date: Wed, 22 Aug 2012 11:09:07 +0000 Subject: [PATCH] VP8 config tunings for improved quality. BUG= Review URL: https://webrtc-codereview.appspot.com/750004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@2656 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../codecs/test/videoprocessor_integrationtest.cc | 2 +- src/modules/video_coding/codecs/vp8/vp8.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc b/src/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc index d8983ac5f..6ae060621 100644 --- a/src/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc +++ b/src/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc @@ -553,7 +553,7 @@ TEST_F(VideoProcessorIntegrationTest, ProcessZeroPacketLoss) { SetCodecParameters(&process_settings, 0.0f, -1, 1, true, true); // Metrics for expected quality. QualityMetrics quality_metrics; - SetQualityMetrics(&quality_metrics, 36.0, 33.0, 0.90, 0.90); + SetQualityMetrics(&quality_metrics, 37.0, 33.0, 0.90, 0.90); // Metrics for rate control. RateControlMetrics rc_metrics[1]; SetRateControlMetrics(rc_metrics, 0, 0, 40, 20, 10, 15, 0); diff --git a/src/modules/video_coding/codecs/vp8/vp8.cc b/src/modules/video_coding/codecs/vp8/vp8.cc index eecf90931..a3d2e2e6d 100644 --- a/src/modules/video_coding/codecs/vp8/vp8.cc +++ b/src/modules/video_coding/codecs/vp8/vp8.cc @@ -238,7 +238,7 @@ int VP8Encoder::InitEncode(const VideoCodec* inst, config_->g_pass = VPX_RC_ONE_PASS; config_->rc_resize_allowed = inst->codecSpecific.VP8.automaticResizeOn ? 1 : 0; - config_->rc_min_quantizer = 8; + config_->rc_min_quantizer = 2; config_->rc_max_quantizer = 56; config_->rc_undershoot_pct = 100; config_->rc_overshoot_pct = 15; @@ -291,7 +291,7 @@ int VP8Encoder::InitAndSetControlSettings(const VideoCodec* inst) { if (vpx_codec_enc_init(encoder_, vpx_codec_vp8_cx(), config_, flags)) { return WEBRTC_VIDEO_CODEC_UNINITIALIZED; } - vpx_codec_control(encoder_, VP8E_SET_STATIC_THRESHOLD, 800); + vpx_codec_control(encoder_, VP8E_SET_STATIC_THRESHOLD, 1); vpx_codec_control(encoder_, VP8E_SET_CPUUSED, cpu_speed_); vpx_codec_control(encoder_, VP8E_SET_TOKEN_PARTITIONS, static_cast(token_partitions_));