generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removing WebRtcNetEQ_GetVersion

Browse Source 
We no longer use version functions.
This should resolve Coverity DefectId 14108

BUG=Coverity DefectId 14108
TEST=trybots, neteq_unittests, audio_coding_unittests, audio_coding_module_test

Review URL: https://webrtc-codereview.appspot.com/792004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@2736 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
henrik.lundin@webrtc.org 2012-09-11 09:23:32 +00:00
parent a63b3db614
commit 1e100a9a5e
3 changed files with 2 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/modules/audio_coding/neteq/interface/webrtc_neteq.h
View File

@ -163,7 +163,6 @@ typedef struct
/* Info functions */
#define WEBRTC_NETEQ_MAX_ERROR_NAME 40
int WebRtcNetEQ_GetVersion(char *version);
int WebRtcNetEQ_GetErrorCode(void *inst);
int WebRtcNetEQ_GetErrorName(int errorCode, char *errorName, int maxStrLen);

11
src/modules/audio_coding/neteq/test/NetEqRTPplay.cc
View File

@ -153,7 +153,6 @@ WebRtc_UWord32 simClock=0;
int main(int argc, char* argv[])
{
std::vector<NETEQTEST_NetEQClass *> NetEQvector;
char version[20];
enum WebRtcNetEQDecoder usedCodec[kDecoderReservedEnd-1];
int noOfCodecs;
@ -187,9 +186,6 @@ int main(int argc, char* argv[])
bool dummyRtp = false;
bool noDecode = false;
/* get the version string */
WebRtcNetEQ_GetVersion(version);
printf("\n\nNetEq version: %s\n", version);
#ifdef DEF_BUILD_DATE
printf("Build time: %s\n", __BUILD_DATE);
#endif
@ -1578,7 +1574,6 @@ void free_coders(std::map<WebRtc_UWord8, decoderStruct> & decoders)
int doAPItest() {
char version[20];
void *inst;
enum WebRtcNetEQDecoder usedCodec;
int NetEqBufferMaxPackets, BufferSizeInBytes;
@ -1588,11 +1583,7 @@ int doAPItest() {
int memorySize;
int ok;
printf("API-test:\n");
/* get the version string */
WebRtcNetEQ_GetVersion(version);
printf("NetEq version: %s\n\n", version);
printf("API-test:\n\n");
/* test that API functions return -1 if instance is NULL */
#define CHECK_MINUS_ONE(x) {int errCode = x; if((errCode)!=-1){printf("\n API test failed at line %d: %s. Function did not return -1 as expected\n",__LINE__,#x); return(-1);}}

15
src/modules/audio_coding/neteq/webrtc_neteq.c
View File

@ -56,22 +56,9 @@ int WebRtcNetEQ_strncpy(char *strDest, int numberOfElements,
*/
/*****************************************
* Info functions
* Error functions
*/
int WebRtcNetEQ_GetVersion(char *version)
{
char versionString[] = "3.3.0\0 ";
char endChar[] = " ";
int i = 0;
while ((versionString[i] != endChar[0]) && (i <= 20))
{
version[i] = versionString[i]; /* To avoid using strcpy */
i++;
}
return (0);
}
int WebRtcNetEQ_GetErrorCode(void *inst)
{
MainInst_t *NetEqMainInst = (MainInst_t*) inst;