generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Disable ProcessThread tests that are dependent on timing.

Browse Source 
Some of the bots are too slow for the tests to make much sense as they are.

TBR=bjornv@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/39869004

Cr-Commit-Position: refs/heads/master@{#8281}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8281 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org 2015-02-07 08:44:28 +00:00
parent 95a32ec098
commit 1d4830a077
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
webrtc/modules/utility/source/process_thread_impl_unittest.cc
View File

@ -160,15 +160,21 @@ void ProcessCallAfterAFewMs(int64_t milliseconds) {
EXPECT_LT(diff, milliseconds + 15);
}
TEST(ProcessThreadImpl, ProcessCallAfter5ms) {
// DISABLED for now since the virtual build bots are too slow :(
// TODO(tommi): Fix.
TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter5ms) {
ProcessCallAfterAFewMs(5);
}
TEST(ProcessThreadImpl, ProcessCallAfter50ms) {
// DISABLED for now since the virtual build bots are too slow :(
// TODO(tommi): Fix.
TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter50ms) {
ProcessCallAfterAFewMs(50);
}
TEST(ProcessThreadImpl, ProcessCallAfter200ms) {
// DISABLED for now since the virtual build bots are too slow :(
// TODO(tommi): Fix.
TEST(ProcessThreadImpl, DISABLED_ProcessCallAfter200ms) {
ProcessCallAfterAFewMs(200);
}
@ -176,7 +182,10 @@ TEST(ProcessThreadImpl, ProcessCallAfter200ms) {
// (on average 1 callback every 20ms). On real hardware, we're usually pretty
// close to that, but the test bots that run on virtual machines, will
// typically be in the range 30-40 callbacks.
TEST(ProcessThreadImpl, MANUAL_Process50Times) {
// DISABLED for now since this can take up to 2 seconds to run on the slowest
// build bots.
// TODO(tommi): Fix.
TEST(ProcessThreadImpl, DISABLED_Process50Times) {
ProcessThreadImpl thread;
ASSERT_EQ(0, thread.Start());