From 19f3f71c9873cf5f6d647becd3620ddf8fd6ba7c Mon Sep 17 00:00:00 2001 From: "pkasting@chromium.org" Date: Mon, 2 Feb 2015 19:44:25 +0000 Subject: [PATCH] Fix apparent typo: int -> char. The surrounding similar methods all used unsigned char, using unsigned int in this case looks like an accident, especially since the function passes on the value in question to a function expecting a uint8. BUG=none TEST=none R=mflodman@webrtc.org Review URL: https://webrtc-codereview.appspot.com/40529004 Cr-Commit-Position: refs/heads/master@{#8228} git-svn-id: http://webrtc.googlecode.com/svn/trunk@8228 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/media/webrtc/fakewebrtcvideoengine.h | 2 +- webrtc/video_engine/include/vie_external_codec.h | 2 +- webrtc/video_engine/vie_external_codec_impl.cc | 2 +- webrtc/video_engine/vie_external_codec_impl.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/talk/media/webrtc/fakewebrtcvideoengine.h b/talk/media/webrtc/fakewebrtcvideoengine.h index 73d9c3553..ca3ed86fd 100644 --- a/talk/media/webrtc/fakewebrtcvideoengine.h +++ b/talk/media/webrtc/fakewebrtcvideoengine.h @@ -1264,7 +1264,7 @@ class FakeWebRtcVideoEngine return 0; } WEBRTC_FUNC(RegisterExternalReceiveCodec, - (const int channel, const unsigned int pl_type, webrtc::VideoDecoder*, + (const int channel, const unsigned char pl_type, webrtc::VideoDecoder*, bool, int)) { WEBRTC_CHECK_CHANNEL(channel); channels_[channel]->ext_decoder_pl_types_.insert(pl_type); diff --git a/webrtc/video_engine/include/vie_external_codec.h b/webrtc/video_engine/include/vie_external_codec.h index 536995ee0..99018dbcd 100644 --- a/webrtc/video_engine/include/vie_external_codec.h +++ b/webrtc/video_engine/include/vie_external_codec.h @@ -34,7 +34,7 @@ class WEBRTC_DLLEXPORT ViEExternalCodec { const unsigned char pl_type) = 0; virtual int RegisterExternalReceiveCodec(const int video_channel, - const unsigned int pl_type, + const unsigned char pl_type, VideoDecoder* decoder, bool decoder_render = false, int render_delay = 0) = 0; diff --git a/webrtc/video_engine/vie_external_codec_impl.cc b/webrtc/video_engine/vie_external_codec_impl.cc index 39a2e63ee..1be2d3161 100644 --- a/webrtc/video_engine/vie_external_codec_impl.cc +++ b/webrtc/video_engine/vie_external_codec_impl.cc @@ -99,7 +99,7 @@ int ViEExternalCodecImpl::DeRegisterExternalSendCodec( int ViEExternalCodecImpl::RegisterExternalReceiveCodec( const int video_channel, - const unsigned int pl_type, + const unsigned char pl_type, VideoDecoder* decoder, bool decoder_render, int render_delay) { diff --git a/webrtc/video_engine/vie_external_codec_impl.h b/webrtc/video_engine/vie_external_codec_impl.h index 7c8f4a20f..da5a445dd 100644 --- a/webrtc/video_engine/vie_external_codec_impl.h +++ b/webrtc/video_engine/vie_external_codec_impl.h @@ -31,7 +31,7 @@ class ViEExternalCodecImpl virtual int DeRegisterExternalSendCodec(const int video_channel, const unsigned char pl_type); virtual int RegisterExternalReceiveCodec(const int video_channel, - const unsigned int pl_type, + const unsigned char pl_type, VideoDecoder* decoder, bool decoder_render = false, int render_delay = 0);