generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

common_audio/signal_processing: Removes macro WEBRTC_SPL_RSHIFT_U16

Browse Source 
This macro is only used at a few places and implies a cast to uint16_t before right shifting. All places already use uint16_t. Further, the amount of shifts applied in the macro has no sanity check for negativity, makes the macro dangerous to use.

BUG=3348,3353
TESTED=trybots and manually
R=kwiberg@webrtc.org, tina.legrand@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/16669004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@6393 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
bjornv@webrtc.org
2014-06-11 06:53:20 +00:00
parent 782978cfcb
commit 18026abd82
5 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/modules/audio_coding/codecs/isac/fix/source/arith_routines_logist.c
View File

@@ -383,7 +383,7 @@ int16_t WebRtcIsacfix_DecLogisticMulti2(int16_t *dataQ7,
streamData->full = 1;
} else {
streamVal = WEBRTC_SPL_LSHIFT_W32(streamVal, 8) |
WEBRTC_SPL_RSHIFT_U16(*streamPtr, 8);
((*streamPtr) >> 8);
streamData->full = 0;
}
} else {