From 174a67439b03cc9c98bcc7fb426ddda8855a0fc2 Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Mon, 2 Jun 2014 07:58:30 +0000 Subject: [PATCH] Enable -Wall, -Wextra and -Wunused-variable for talk/ on clang. Also removes one case of unused-variable. BUG=3220 R=henrike@webrtc.org, kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/15619005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6297 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/app/webrtc/webrtcsession_unittest.cc | 2 -- talk/build/common.gypi | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc index b6f726b34..956f8a66f 100644 --- a/talk/app/webrtc/webrtcsession_unittest.cc +++ b/talk/app/webrtc/webrtcsession_unittest.cc @@ -105,8 +105,6 @@ static const char kClientAddrHost2[] = "22.22.22.22"; static const char kStunAddrHost[] = "99.99.99.1"; static const SocketAddress kTurnUdpIntAddr("99.99.99.4", 3478); static const SocketAddress kTurnUdpExtAddr("99.99.99.6", 0); -static const char kTurnUsername[] = "test"; -static const char kTurnPassword[] = "test"; static const char kSessionVersion[] = "1"; diff --git a/talk/build/common.gypi b/talk/build/common.gypi index 63ad9abf6..8261c2085 100644 --- a/talk/build/common.gypi +++ b/talk/build/common.gypi @@ -86,6 +86,9 @@ 'conditions': [ ['clang==1', { 'cflags': [ + '-Wall', + '-Wextra', + '-Wunused-variable', # TODO(ronghuawu): Fix the warning caused by # LateBindingSymbolTable::TableInfo from # latebindingsymboltable.cc.def and remove below flag.