generic-library/webrtc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert 8273 "Temporarily change ThreadPosix to CHECK (crash) if ..."

Browse Source 
> Temporarily change ThreadPosix to CHECK (crash) if we ever spend more than 30 seconds waiting for thread shutdown. There are cases on build bots where it looks like we're hitting this problem, but reproducing locally has been a struggle.
> 
> TBR=pbos@webrtc.org
> 
> Review URL: https://webrtc-codereview.appspot.com/41799004

TBR=tommi@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/38039004

Cr-Commit-Position: refs/heads/master@{#8300}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8300 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
tommi@webrtc.org 2015-02-09 16:31:31 +00:00
parent 0d852d5c27
commit 11c5db01af
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/system_wrappers/source/thread_posix.cc
View File

@ -110,10 +110,7 @@ bool ThreadPosix::Start(unsigned int& thread_id) {
if (result != 0)
return false;
// TODO(tommi): Change the timeout back to WEBRTC_EVENT_INFINITE when we've
// figured out where we're seeing tests hang.
auto state = params.started->Wait(30 * 1000);
CHECK_EQ(kEventSignaled, state);
CHECK_EQ(kEventSignaled, params.started->Wait(WEBRTC_EVENT_INFINITE));
DCHECK_NE(thread_id_, 0);
thread_id = thread_id_;