Fixed comments and added new flags for the PyAuto test.
The ChromeBloat bot will now also be ignored for LKGRs. BUG= TEST= Review URL: https://webrtc-codereview.appspot.com/559004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@2169 4adac7df-926f-26a2-2b94-8c16560cd09d
This commit is contained in:
@@ -315,8 +315,7 @@ class WebRTCFactory(factory.BuildFactory):
|
||||
character is found, no space will be inserted.
|
||||
Returns:
|
||||
A new list of the same length as the input list, but with strings
|
||||
that may contain extra spaces in them, if longer than the max
|
||||
length.
|
||||
that may contain extra spaces in them, if longer than the max length.
|
||||
"""
|
||||
result = []
|
||||
for line in string_list:
|
||||
@@ -589,7 +588,8 @@ class WebRTCChromeFactory(WebRTCFactory):
|
||||
# Replace any slashes in the test's path with underscores for the name since
|
||||
# the buildbot web pages will become confused otherwise.
|
||||
descriptor = test.replace('/', '_')
|
||||
pyauto_flags = ' --chrome-flags --enable-media-stream'
|
||||
pyauto_flags = (' --chrome-flags "--enable-media-stream'
|
||||
' --enable-peer-connection"')
|
||||
cmd = MakeCommandToRunTestInXvfb(test + pyauto_flags)
|
||||
self.AddCommonStep(cmd=cmd, descriptor=descriptor, workdir='build/src')
|
||||
|
||||
@@ -674,7 +674,7 @@ class WebRTCLinuxFactory(WebRTCFactory):
|
||||
|
||||
def AddXvfbTestRunStep(self, test_name, test_binary, test_arguments=''):
|
||||
""" Adds a test to be run inside a XVFB window manager."""
|
||||
cmd = MakeCommandToRunTestInXvfb("%s %s" % (test_binary, test_arguments))
|
||||
cmd = MakeCommandToRunTestInXvfb('%s %s' % (test_binary, test_arguments))
|
||||
self.AddCommonTestRunStep(test=test_name, cmd=cmd)
|
||||
|
||||
def AddCommonMakeStep(self, target, extra_text=None, make_extra=None):
|
||||
|
||||
Reference in New Issue
Block a user