generic-library/webp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

thread_utils: fix potentially bad call to Execute

Browse Source 
We must use the Interface, and avoid fwd decl.

Change-Id: I18d77a009a29921b6e3694de4df494952b11a83f
This commit is contained in:
Pascal Massimino 2017-11-05 16:39:29 -08:00
parent 6ba98764e8
commit fde2782ecb
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/utils/thread_utils.c
View File

@ -201,8 +201,6 @@ static int pthread_cond_wait(pthread_cond_t* const condition,
//------------------------------------------------------------------------------ //------------------------------------------------------------------------------
static void Execute(WebPWorker* const worker); // Forward declaration.
static THREADFN ThreadLoop(void* ptr) { static THREADFN ThreadLoop(void* ptr) {
WebPWorker* const worker = (WebPWorker*)ptr; WebPWorker* const worker = (WebPWorker*)ptr;
int done = 0; int done = 0;
@ -212,7 +210,7 @@ static THREADFN ThreadLoop(void* ptr) {
pthread_cond_wait(&worker->impl_->condition_, &worker->impl_->mutex_); pthread_cond_wait(&worker->impl_->condition_, &worker->impl_->mutex_);
} }
if (worker->status_ == WORK) { if (worker->status_ == WORK) {
Execute(worker); WebPGetWorkerInterface()->Execute(worker);
worker->status_ = OK; worker->status_ = OK;
} else if (worker->status_ == NOT_OK) { // finish the worker } else if (worker->status_ == NOT_OK) { // finish the worker
done = 1; done = 1;