generic-library/webp
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Remove some very hard TODOs."

Browse Source
This commit is contained in:
Pascal Massimino 2018-04-03 14:10:50 +00:00 committed by Gerrit Code Review
commit 994be82d00
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/enc/histogram_enc.c
View File

@ -1026,7 +1026,7 @@ int VP8LGetHistoImageSymbols(int xsize, int ysize,
} }
} }
// TODO(vikasa): Optimize HistogramRemap for low-effort compression mode also. // TODO(vrabaud): Optimize HistogramRemap for low-effort compression mode.
// Find the optimal map from original histograms to the final ones. // Find the optimal map from original histograms to the final ones.
HistogramRemap(orig_histo, image_histo, histogram_symbols); HistogramRemap(orig_histo, image_histo, histogram_symbols);

5
src/enc/vp8l_enc.c
View File

@ -382,8 +382,7 @@ static int EncoderAnalyze(VP8LEncoder* const enc,
AnalyzeAndCreatePalette(pic, low_effort, AnalyzeAndCreatePalette(pic, low_effort,
enc->palette_, &enc->palette_size_); enc->palette_, &enc->palette_size_);
// TODO(jyrki): replace the decision to be based on an actual estimate // Empirical bit sizes.
// of entropy, or even spatial variance of entropy.
enc->histo_bits_ = GetHistoBits(method, use_palette, enc->histo_bits_ = GetHistoBits(method, use_palette,
pic->width, pic->height); pic->width, pic->height);
enc->transform_bits_ = GetTransformBits(method, enc->histo_bits_); enc->transform_bits_ = GetTransformBits(method, enc->histo_bits_);
@ -754,7 +753,6 @@ static WebPEncodingError StoreImageToBitMask(
// Don't write the distance with the extra bits code since // Don't write the distance with the extra bits code since
// the distance can be up to 18 bits of extra bits, and the prefix // the distance can be up to 18 bits of extra bits, and the prefix
// 15 bits, totaling to 33, and our PutBits only supports up to 32 bits. // 15 bits, totaling to 33, and our PutBits only supports up to 32 bits.
// TODO(jyrki): optimize this further.
VP8LPrefixEncode(distance, &code, &n_bits, &bits); VP8LPrefixEncode(distance, &code, &n_bits, &bits);
WriteHuffmanCode(bw, codes + 4, code); WriteHuffmanCode(bw, codes + 4, code);
VP8LPutBits(bw, bits, n_bits); VP8LPutBits(bw, bits, n_bits);
@ -1876,7 +1874,6 @@ int VP8LEncodeImage(const WebPConfig* const config,
err = VP8LEncodeStream(config, picture, &bw, 1 /*use_cache*/); err = VP8LEncodeStream(config, picture, &bw, 1 /*use_cache*/);
if (err != VP8_ENC_OK) goto Error; if (err != VP8_ENC_OK) goto Error;
// TODO(skal): have a fine-grained progress report in VP8LEncodeStream().
if (!WebPReportProgress(picture, 90, &percent)) goto UserAbort; if (!WebPReportProgress(picture, 90, &percent)) goto UserAbort;
// Finish the RIFF chunk. // Finish the RIFF chunk.