generic-library/webm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

webm_parser: Enable usage of werror.

Browse Source 
Mass warning clean up. Mainly:
- Explicit casts of numeric literals to avoid signed/unsigned compare
  warnings.
- Commenting out of unused function arg names.

Change-Id: I0e70393a5743ae984035d43712c724d4ccd12f9d
This commit is contained in:
Tom Finegan
2016-08-08 14:47:42 -07:00
parent e1fe7627c8
commit d518128266
39 changed files with 346 additions and 324 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
webm_parser/tests/parser_utils_test.cc
View File

@@ -73,28 +73,28 @@ TEST_F(ParserUtilsTest, AccumulateIntegerBytes) {
status =
AccumulateIntegerBytes(4, &reader, &integer, &num_bytes_actually_read);
EXPECT_EQ(Status::kWouldBlock, status.code);
EXPECT_EQ(1, num_bytes_actually_read);
EXPECT_EQ(0x12, integer);
EXPECT_EQ(static_cast<std::uint64_t>(1), num_bytes_actually_read);
EXPECT_EQ(static_cast<std::uint32_t>(0x12), integer);
reader.set_total_read_limit(std::numeric_limits<std::size_t>::max());
status =
AccumulateIntegerBytes(3, &reader, &integer, &num_bytes_actually_read);
EXPECT_EQ(Status::kOkCompleted, status.code);
EXPECT_EQ(3, num_bytes_actually_read);
EXPECT_EQ(0x12345678, integer);
EXPECT_EQ(static_cast<std::uint64_t>(3), num_bytes_actually_read);
EXPECT_EQ(static_cast<std::uint32_t>(0x12345678), integer);
// Make sure calling with num_bytes_remaining == 0 is a no-op.
status =
AccumulateIntegerBytes(0, &reader, &integer, &num_bytes_actually_read);
EXPECT_EQ(Status::kOkCompleted, status.code);
EXPECT_EQ(0, num_bytes_actually_read);
EXPECT_EQ(0x12345678, integer);
EXPECT_EQ(static_cast<std::uint64_t>(0), num_bytes_actually_read);
EXPECT_EQ(static_cast<std::uint32_t>(0x12345678), integer);
status =
AccumulateIntegerBytes(4, &reader, &integer, &num_bytes_actually_read);
EXPECT_EQ(Status::kEndOfFile, status.code);
EXPECT_EQ(0, num_bytes_actually_read);
EXPECT_EQ(0x12345678, integer);
EXPECT_EQ(static_cast<std::uint64_t>(0), num_bytes_actually_read);
EXPECT_EQ(static_cast<std::uint32_t>(0x12345678), integer);
}
} // namespace