generic-library/webm
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

webm_parser: Enable usage of werror.

Browse Source 
Mass warning clean up. Mainly:
- Explicit casts of numeric literals to avoid signed/unsigned compare
  warnings.
- Commenting out of unused function arg names.

Change-Id: I0e70393a5743ae984035d43712c724d4ccd12f9d
This commit is contained in:
Tom Finegan
2016-08-08 14:47:42 -07:00
parent e1fe7627c8
commit d518128266
39 changed files with 346 additions and 324 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
webm_parser/tests/audio_parser_test.cc
View File

@@ -33,10 +33,10 @@ TEST_F(AudioParserTest, DefaultParse) {
EXPECT_EQ(8000, audio.output_frequency.value());
EXPECT_FALSE(audio.channels.is_present());
EXPECT_EQ(1, audio.channels.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.channels.value());
EXPECT_FALSE(audio.bit_depth.is_present());
EXPECT_EQ(0, audio.bit_depth.value());
EXPECT_EQ(static_cast<std::uint64_t>(0), audio.bit_depth.value());
}
TEST_F(AudioParserTest, DefaultValues) {
@@ -65,10 +65,10 @@ TEST_F(AudioParserTest, DefaultValues) {
EXPECT_EQ(8000, audio.output_frequency.value());
EXPECT_TRUE(audio.channels.is_present());
EXPECT_EQ(1, audio.channels.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.channels.value());
EXPECT_TRUE(audio.bit_depth.is_present());
EXPECT_EQ(0, audio.bit_depth.value());
EXPECT_EQ(static_cast<std::uint64_t>(0), audio.bit_depth.value());
}
TEST_F(AudioParserTest, CustomValues) {
@@ -95,16 +95,16 @@ TEST_F(AudioParserTest, CustomValues) {
const Audio audio = parser_.value();
EXPECT_TRUE(audio.sampling_frequency.is_present());
EXPECT_EQ(1, audio.sampling_frequency.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.sampling_frequency.value());
EXPECT_TRUE(audio.output_frequency.is_present());
EXPECT_EQ(1.73205077648162841796875, audio.output_frequency.value());
EXPECT_TRUE(audio.channels.is_present());
EXPECT_EQ(2, audio.channels.value());
EXPECT_EQ(static_cast<std::uint64_t>(2), audio.channels.value());
EXPECT_TRUE(audio.bit_depth.is_present());
EXPECT_EQ(1, audio.bit_depth.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.bit_depth.value());
}
TEST_F(AudioParserTest, AbsentOutputSamplingFrequency) {
@@ -119,16 +119,16 @@ TEST_F(AudioParserTest, AbsentOutputSamplingFrequency) {
const Audio audio = parser_.value();
EXPECT_TRUE(audio.sampling_frequency.is_present());
EXPECT_EQ(1, audio.sampling_frequency.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.sampling_frequency.value());
EXPECT_FALSE(audio.output_frequency.is_present());
EXPECT_EQ(1, audio.output_frequency.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.output_frequency.value());
EXPECT_FALSE(audio.channels.is_present());
EXPECT_EQ(1, audio.channels.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.channels.value());
EXPECT_FALSE(audio.bit_depth.is_present());
EXPECT_EQ(0, audio.bit_depth.value());
EXPECT_EQ(static_cast<std::uint64_t>(0), audio.bit_depth.value());
}
TEST_F(AudioParserTest, DefaultOutputSamplingFrequency) {
@@ -146,16 +146,16 @@ TEST_F(AudioParserTest, DefaultOutputSamplingFrequency) {
const Audio audio = parser_.value();
EXPECT_TRUE(audio.sampling_frequency.is_present());
EXPECT_EQ(1, audio.sampling_frequency.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.sampling_frequency.value());
EXPECT_TRUE(audio.output_frequency.is_present());
EXPECT_EQ(1, audio.output_frequency.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.output_frequency.value());
EXPECT_FALSE(audio.channels.is_present());
EXPECT_EQ(1, audio.channels.value());
EXPECT_EQ(static_cast<std::uint64_t>(1), audio.channels.value());
EXPECT_FALSE(audio.bit_depth.is_present());
EXPECT_EQ(0, audio.bit_depth.value());
EXPECT_EQ(static_cast<std::uint64_t>(0), audio.bit_depth.value());
}
} // namespace