John Koleszar
89d66cbb20
Merge remote branch 'internal/upstream' into HEAD
2011-03-05 00:05:05 -05:00
John Koleszar
0bc31f1887
Merge "Fixing divide by zero"
2011-03-04 05:40:33 -08:00
John Koleszar
fb37eda3e2
Merge "Fix drastic undershoot in long form content"
2011-03-04 05:39:40 -08:00
John Koleszar
eed2ce58e3
Merge "Fix counter of fixed keyframe distance"
2011-03-04 05:28:38 -08:00
Mikhal Shemer
1de99a2a81
Fixing divide by zero
...
Change-Id: I9d8a98a2f7ed1e3116d0bae35164618c41998bac
2011-03-03 10:33:36 -08:00
John Koleszar
ca29f6a7c4
Merge remote branch 'internal/upstream' into HEAD
...
Conflicts:
vp8/vp8_cx_iface.c
Change-Id: Iecfd4532ab1c722d10ecce8a5ec473e96093cf3b
2011-03-03 08:59:34 -05:00
John Koleszar
738a791917
Merge remote branch 'internal/upstream-experimental' into HEAD
...
Conflicts:
vp8/common/blockd.h
Change-Id: Ica2bd1c3da614eab5ce23acfb597e777d16b3983
2011-03-03 08:58:57 -05:00
John Koleszar
36be4f7f06
Fix drastic undershoot in long form content
...
When the modified_error_left accumulator exceeds INT_MAX, an incorrect
cast to int resulted in a negative value, causing the rate control to
allocate no bits to that keyframe group, leading to severe undershoot
and subsequent poor quality.
This error was exposed by the recent change to the rolling target and
actual spend accumulators in commit 305be4e4
which fixed them to
actually calculate the average value rather than be re-initialized
on every frame to the average per-frame bitrate. When this bug was
triggered, the target bitrate could be 0, so the rolling target
becomes small, which causes the undershoot. The code prior to 305be4e4
did not exhibit this behavior because the rolling target was always
set to a reasonable value and was independent of the actual target
bitrate. With this patch, the actual target bitrate is calculated
correctly, and the rate control tracks as expected.
This cast was likely added to silence a compiler warning on a comparison
between a double (modified_error_left) and an int (0). Instead, this
patch removes the cast and changes the comparison to be against 0.0,
which should prevent the warning from reoccuring.
This fixes issue #289 . Special thanks to gnafu for his efforts in
reporting and debugging this fix.
Change-Id: Ie5cc1a7b516c578a76c3a50c892a6f04a11621fe
2011-03-02 22:52:27 -05:00
Johann
6f5189c044
Merge "ARMv6 optimized half pixel variance calculations"
2011-03-02 05:48:46 -08:00
Yunqing Wang
cfaee9f7c6
Merge "Add prefetch before variance calculation"
2011-02-28 11:42:28 -08:00
Scott LaVarnway
3e6d476ac3
Merge "Avoid double copying of key frames into alt and golden buffer"
2011-02-28 10:16:33 -08:00
Yunqing Wang
d96ba65a23
Add prefetch before variance calculation
...
This improved encoding performance by 0.5% (good, speed 1) to
1.5% (good, speed 5).
Change-Id: I843d72a0d68a90b5f694adf770943e4a4618f50e
2011-02-28 11:25:55 -05:00
Johann
31dab574cc
Merge "Remove a second check for invalid ptr in vp8_get_compressed_data"
2011-02-25 11:44:18 -08:00
Johann
e4fa638653
Merge "Remove temporal alt ref from realtime only build"
2011-02-25 06:55:17 -08:00
Johann
1fae7018a8
Merge "Handle mem allocation failure in vp8e_init"
2011-02-25 06:55:10 -08:00
Attila Nagy
d8fc974ac0
Avoid double copying of key frames into alt and golden buffer
...
Change-Id: I726976a297a593a35ed6cba3c660e372562f7b27
2011-02-25 09:03:16 +02:00
Attila Nagy
6da2018789
Remove a second check for invalid ptr in vp8_get_compressed_data
...
Check is done first when function si entered.
Change-Id: Ief0d0cbd4860aaf492b78728f8d22f24029b1174
2011-02-25 08:41:13 +02:00
John Koleszar
1a7ce50a6c
Merge remote branch 'origin/master' into experimental
...
Change-Id: I52f21ff6f9a1dca7099a8459657f6f288c5bfe40
2011-02-25 00:05:08 -05:00
Scott LaVarnway
861175ef00
Removed vp8_block2type
...
and used defines instead.
Change-Id: Idb56e0295d004793f406dfd2d8d8c546aad62e03
2011-02-24 14:35:18 -05:00
Scott LaVarnway
d53492bba4
Merge "Revisited rd_pick_intra4x4block"
2011-02-24 11:25:21 -08:00
Scott LaVarnway
658454a04c
Revisited rd_pick_intra4x4block
...
Removed unnecessary copies. No noticeable speed gains.
Change-Id: I996c50c23fedd06d54ee7a3e762cbf559cc4a9d1
2011-02-24 13:31:47 -05:00
Paul Wilkins
b862c108dd
Overflow of frame error accumulators.
...
This fixes an overflow problem in the frame error accumulators.
The overflow condition is extreme but did trigger when Frank B.
coded some high motion interlaced HD content.
The observed effect was a catastrophic breakdown of the rate
control leading to massive undershoot and poor bit allocation.
All the error values should really be unsigned but I will look at this
separately.
Change-Id: I9745f5c5ca2783620426b66b568b2088b579151f
2011-02-24 15:49:41 +00:00
Tero Rintaluoma
8ae92aef66
ARMv6 optimized half pixel variance calculations
...
Adds following ARMv6 optimized functions to the encoder:
- vp8_variance_halfpixvar16x16_h_armv6
- vp8_variance_halfpixvar16x16_v_armv6
- vp8_variance_halfpixvar16x16_hv_armv6
Change-Id: I1e9c2af7acd2a51b72b3845beecd990db4bebd29
2011-02-23 13:27:27 +02:00
Attila Nagy
e6db21ecc4
Handle mem allocation failure in vp8e_init
...
Change-Id: I0d0445c57eb0889082f83de1948852d57b38fefb
2011-02-23 12:36:03 +02:00
Attila Nagy
7af0d906e3
Remove temporal alt ref from realtime only build
...
It is not used in realtime mode. Reduces memory footprint.
Change-Id: I7f163225762368df5457cfd413050161d3704a3f
2011-02-22 12:53:32 +02:00
John Koleszar
b21fe3b278
Merge remote branch 'internal/upstream' into HEAD
2011-02-19 00:05:44 -05:00
John Koleszar
bbfca323fb
Merge remote branch 'origin/master' into experimental
...
Change-Id: Ia3197f432b424213a34b20071e5171a413ba1aaf
2011-02-19 00:05:11 -05:00
Johann
945dad277d
Revert "use unaligned load"
...
This reverts commit f50f2fd2a7
.
Change Ib7506e3e aligns the buffer
Change-Id: Ie0f8bd3e57cfdfef81d39638a1451458ebbae2e0
2011-02-18 10:23:02 -05:00
John Koleszar
c764c2a20f
Merge "clean up unused files"
2011-02-18 06:33:05 -08:00
John Koleszar
3ed8fe8778
remove unused vp8_predict_dc function
...
Change-Id: I64fa47889c54cfed094a674c49ef0996d49bdd42
2011-02-18 09:12:20 -05:00
John Koleszar
cbf923b12c
clean up unused files
...
Removed a number of files that were unused or little-used.
Change-Id: If9ae5e5b11390077581a9a879e8a0defe709f5da
2011-02-18 09:09:49 -05:00
John Koleszar
d371ca93e5
cosmetic: remove unnecessary scope
...
Clean up some unnecessary scoping around pick_filter_level.
Change-Id: Ic57fa33e3fcae37fe6beae977e5743783399d5af
2011-02-18 08:46:07 -05:00
John Koleszar
597d02b508
Merge "Dont pick encoder filter level when loopfilter is disabled."
2011-02-18 05:26:23 -08:00
Attila Nagy
fb5a692d27
Reinitialize quantizer only when any delta is changing
...
No need to reinitialize for base Q changes.
Change-Id: Ie76ec21dd3c5582d5183dbed75ed73a1eed3e291
2011-02-18 14:23:37 +02:00
Attila Nagy
c6ef75690f
Dont pick encoder filter level when loopfilter is disabled.
...
Change-Id: I58154faf4f3ece24f9927a5c3ab7e830e0887fb6
2011-02-18 08:53:00 +02:00
John Koleszar
f13212b728
Merge remote branch 'internal/upstream' into HEAD
2011-02-18 00:05:13 -05:00
John Koleszar
4fafc4d985
Merge remote branch 'origin/master' into experimental
...
Change-Id: I8999a33db82d38eb85482f3c423db238d6ee3ed9
2011-02-18 00:05:11 -05:00
John Koleszar
b2ae57f1b6
Merge "Use endian-neutral bitstream packing/unpacking"
2011-02-17 12:34:16 -08:00
John Koleszar
562f1470ce
Use endian-neutral bitstream packing/unpacking
...
Eliminate unnecessary checks on target endianness and associated
macros.
Change-Id: I1d4e6a9dcee9bfc8940c8196838d31ed31b0e4aa
2011-02-17 15:20:53 -05:00
John Koleszar
ac10665ad8
Merge "Removed unused vp8_recon_intra4x4mb function"
2011-02-17 11:30:13 -08:00
Scott LaVarnway
07f7b66fae
Removed unused vp8_recon_intra4x4mb function
...
Change-Id: I4a328ce152d9dbe6b0d1606d1b523e8e7bfb468e
2011-02-17 13:34:38 -05:00
John Koleszar
c351aa7f1b
Merge "Fix relative include paths"
2011-02-17 04:13:44 -08:00
John Koleszar
c88dbb2dce
Merge remote branch 'internal/upstream' into HEAD
2011-02-17 00:05:14 -05:00
John Koleszar
1293116895
Merge remote branch 'origin/master' into experimental
...
Change-Id: I3efb725e4da4e7c75b2512b80db6af51dec51f79
2011-02-17 00:05:13 -05:00
Yunqing Wang
da9402fbf6
Merge "Allocate source buffers to be multiples of 16"
2011-02-16 11:35:06 -08:00
Yunqing Wang
da227b901d
Allocate source buffers to be multiples of 16
...
Currently, when the video frame width is not multiples of 16, the
source buffer has a stride of non-multiples of 16, which forces
an unaligned load in SAD function and hurts the performance. To
avoid that, this change allocates source buffers to be multiples
of 16.
Change-Id: Ib7506e3eb2cea06657d56be5a899f38dfe3eeb39
2011-02-16 12:57:17 -05:00
Johann
0c2cfff9b0
Merge "ARMv6 optimized sad16x16"
2011-02-16 05:22:38 -08:00
John Koleszar
e786bd3a01
Merge remote branch 'internal/upstream' into HEAD
2011-02-16 00:05:13 -05:00
John Koleszar
9e95a1a0cd
Merge remote branch 'origin/master' into experimental
...
Change-Id: If846b0e4ec862b54b98d08608f4b5f9a7b7f94ef
2011-02-16 00:05:10 -05:00
James Zern
0030303b69
Remove redundant ptr checks in calls to vpx_free
...
vpx_free if used contains this check. If replaced, well behaved free
will behave similarly.
Change-Id: I25483aaa8b39255b9a8cf388d6e5eaa20a908ae1
2011-02-15 12:43:35 -08:00