102 Commits

Author SHA1 Message Date
John Koleszar
9e44920247 dixie: cosmetics (line length, braces, etc)
Pass code through AStyle transform, wrap long lines.

Change-Id: Icffa4fc3e9835ec152285ae0e98a1ff3f46e42e6
2011-03-08 13:00:10 -05:00
John Koleszar
246cc0881a dixie: remove unused variables
Change-Id: I9c9d83f441bbe1f268c2610e88d72f7a4adb353e
2011-02-08 09:50:20 -05:00
John Koleszar
51f9ef8e89 dixie: only use sixtap mc filter
Remove all the special case 2-tap, 4-tap, 16x16, 8x8, etc filters,
and instead just use one 2D 6-tap 4x4 filter.

Change-Id: I9ec560fb5609d1a3160e9a3d8b396911073517a0
2011-02-08 09:41:27 -05:00
John Koleszar
9f40e5650c dixie: simplify inter prediction
Always use 4x4 modes rather than special casing 2,4,16 blocks.

Change-Id: I0301da4b0ff1885d79c1ae07b084d2d9b7487f72
2011-02-07 11:53:00 -05:00
John Koleszar
252703291f dixie: simplify intra prediction
Removed all the special case intra prediction code for clarity.

Change-Id: I54c2435aedb2b5b00e668aa9e6d7c332af9cda3f
2011-02-07 09:25:22 -05:00
John Koleszar
26f91d31d1 dixie: simplify bool decoder
Use the simplified bool decoder from the bitstream guide, slightly
modified to prevent reading past the end of the buffer. Modified
the token decoder to use the normal bool decoder rather than
inlining its own.

Change-Id: Ic525e773e9f8331ba548a6505cc6d9e5372a5af0
2011-02-03 09:04:26 -05:00
John Koleszar
3688076d42 dixie: fix memory leaks
Implemented the decoder shutdown call to deallocate buffers when the
codec is destroyed.

Change-Id: I6cd62f40f34e0db91fb7eb8cb673f5d9726fe192
2011-02-03 00:26:37 -05:00
John Koleszar
52a1b7df97 dixie: handle buffer size changes
spatial resampling now supported.

Change-Id: Ifd959072b76ac3f8eeed00a0fd25acdde036defe
2011-02-03 00:07:32 -05:00
John Koleszar
def479510e dixie: support for simple lf, bilinear subpix
Initial support for simple loopfilter and bilinear subpixel motion
interpolation. This adds support for VP8 profiles 1-3 to dixie.

Change-Id: I76d45cf9843f6f7473783b7932af94f033eb6e82
2011-02-02 16:54:35 -05:00
John Koleszar
e75a400cd3 dixie: prevent read of uninitialized memory
When reallocating the framebuffer storage, clear references to the
freed memory to prevent it from being accessed.

Change-Id: Ib496b06be469328e8e269f905dc4c9cb6d453a27
2011-02-01 16:15:45 -05:00
John Koleszar
dbb7db5b43 dixie: correct reference buffer copies
The copy_{gf,arf} flags should copy the LAST buffer to the specified
buffer. The refresh_{gf,arf} flags should copy the CURRENT buffer to
the specified buffer.

Change-Id: I1fdf014c439b1ce584cda3d56841243fbfbb1f0a
2011-02-01 16:09:44 -05:00
John Koleszar
c565409a2a dixie: populate all dequant_factors
Missed incrementing the pointer, so only the first segment would be
populated.

Change-Id: I94419b2c678c8706ffe6e71bd134f3cf7853ba68
2011-02-01 16:07:52 -05:00
John Koleszar
6f2e4e1987 dixie: correct delta_q parsing
Cut and paste error caused UV delta Qs to overwrite Y1 DC delta Q.

Change-Id: I213506d830dbb54aa4cb100d56e0814ae10e0e2d
2011-02-01 16:06:16 -05:00
John Koleszar
f46f53d0de dixie: correct frame size check
Interframes have 3 byte headers, keyframes have 10 bytes.

Change-Id: I3886cb87dbc8ae175f82776f27c85603ca977af9
2011-02-01 14:12:41 -05:00
John Koleszar
37693cfd5a dixie: fix process_row when start_col>0
Change-Id: Ie3704c2ceb94fa3e49cd07a8c473b116b704a692
2010-08-06 15:30:51 -04:00
John Koleszar
0f15bbde8f dixie: add split four/six tap 2d filters
Change-Id: I7e2a20c129f9bb5a6a51833e0c5d659742c3b842
2010-08-06 15:30:51 -04:00
John Koleszar
754e60a64d dixie: fix 64 bit integer promotion issue.
Change-Id: I8efbed8fc79f9c1da3c84434c5b54c5100cbff0b
2010-08-06 15:30:50 -04:00
John Koleszar
da4255792a dixie: use emulated umv border
Change-Id: Ib6f6f2c20b11bc9b41847c097ab3a4a0025399b7
2010-08-06 15:30:49 -04:00
John Koleszar
421146312b dixie: add interframe reconstruction
This patch adds basic reconstruction for inter-predicted frames. It does
not properly handle clamping at the MV border.

Change-Id: Ib7e4395519aab0661a38f4e0f66972b5f08805cb
2010-08-05 10:46:13 -04:00
John Koleszar
829e2af0e1 dixie: add normal loopfilter
This is the more naive implementation as described in the bitstream guide,
rather than the masking version implemented in the reference code. However,
the core function prototypes were left as-is to make it easy to plug in the
reference assembly code.

Verified loopfiltered output matches reference decoder for 500 frames.

Change-Id: Ib4f197e864f07dbb918b6d5e742c6110d57c1f40
2010-07-12 16:36:57 -04:00
John Koleszar
06c0623219 dixie: add idct/add stage
Verified reconstructed (but not loopfiltered) output matches reference
decoder for 500 frames.

Change-Id: Iaa0c4bdd7733f1958cf2b8ed40d4c78f9028e298
2010-07-07 13:30:54 -04:00
John Koleszar
cf7705579b dixie: add intra prediction
This commit adds prediction functions for all the intra modes.

Change-Id: I626e245318f96ee2ce0d965d7454ac7dce0cff79
2010-07-07 13:29:42 -04:00
John Koleszar
940599ff2c dixie: combine dequant with token decode
Scales as O(number-of-tokens) rather than O(16).

Change-Id: Ic67b81289eeef7fedacd0b5973b7c06e5a507f29
2010-07-07 13:29:19 -04:00
John Koleszar
86262018ad dixie: implement token decoding
Verified decoded tokens match reference for all profile 0 test
vectors.

Change-Id: I3e5f7431cb0fbe7130331c82b434c4fd67f839cb
2010-06-24 15:00:26 -04:00
John Koleszar
b52ee87d2c dixie: sync bool decoder to latest
Incorporate the VP8DX_BOOL_DECODER_FILL macro, which is referenced by
the token decoder.

Change-Id: I32850279476d759e921634aa05c852217a571619
2010-06-24 15:00:25 -04:00
John Koleszar
9a63ff2243 dixie: move modemv data tables
Move these tables to their own file, to make modemv.c more readable.

Change-Id: I0c97e51c5b4601348f465be53e1c4b3c88cc7834
2010-06-24 15:00:24 -04:00
John Koleszar
41bad1f258 dixie: implement motion vector decoding
Verified decoded motion vectors match reference for all profile 0
test vectors.

Change-Id: Iee54bb4c37a32ca4493fa5694d7d29177fd6faa0
2010-06-24 15:00:24 -04:00
John Koleszar
29e1dea8cd dixie: implement keyframe mode decoding
Verified decoded modes matched reference decoder for 1 frame.

Change-Id: I69303aff8fa975dccc943bfe277ea86d55d75147
2010-06-24 15:00:22 -04:00
John Koleszar
c9ebe27ce4 dixie: decode entropy model header
Change-Id: I7a6cc0ac5656b50cac90c93a95adaecfe16efb72
2010-06-24 15:00:21 -04:00
John Koleszar
ca50290d6c dixie: decode reference frame header
Change-Id: I35a11c46d46430984cdcaf0ff7ef5f42f372d3c7
2010-06-24 15:00:20 -04:00
John Koleszar
476d59a304 dixie: decode quantizer level header
Change-Id: Ie8fe79280bcdae1b25ab69470d58ec4efee198d2
2010-06-24 15:00:19 -04:00
John Koleszar
f2274a34e6 dixie: decode token partitions header
Change-Id: Id894ef22c1a22a426fa4fcf3a3733711b723b9ec
2010-06-24 15:00:17 -04:00
John Koleszar
8d6fbc1bdf dixie: decode loopfilter header
Change-Id: Iab649cdb114d15e70ea632da911d8e3f5abbf36b
2010-06-24 15:00:15 -04:00
John Koleszar
948b1d4283 dixie: decode segmentation header
Change-Id: Id46c6f50ee60419ae1387baf74673af02475203d
2010-06-24 15:00:13 -04:00
John Koleszar
f766f3c8f3 dixie: simple validation of the frame header
Change-Id: Iae8c2d421eb686d652807d44d8053eaec8f72897
2010-06-24 15:00:12 -04:00
John Koleszar
5c263fa3ca dixie: initial interface
The "dixie" project will be a rewrite of much of the VP8 decoder core.
Some of the goals are:

  * Increase speed by paying more attention to data locality and
    cache layout, and by eliminating redundant work in general.

  * A different approach to multithreading, to treat all threads as
    equal and working on larger work units than a single MB.

  * Expose more of the bitstream to the application, essentially
    creating a vp8 parser utility. This could be useful for analyzing
    the complexity of a stream, to help set conformance points.

  * If the above goals are met successfully, replace the reference
    decoder.

For those interested in the etymology of the term "dixie:"
  decoder2 -> dx2 -> dxii -> dixie

Change-Id: I4ef0832b62ea96e9cfa1906c4a77f4b51e0c62d6
2010-06-24 15:00:06 -04:00
agrange
a08df4552a Fix breakout thresh computation for golden & AltRef frames
1. Unavailability of each reference frame type should be tested
independently,
2. Also, only the VP8_GOLD_FLAG needs to be tested before setting
golden frame specific thresholds, and only VP8_ALT_FLAG needs
testing before setting thresholds relevant to the AltRef frame.
(Raised by gbvalor, in response to Issue 47)

Change-Id: I6a06fc2a6592841d85422bc1661e33349bb6c3b8
2010-06-21 16:50:59 +01:00
agrange
daa5d0eb3d Changed unary operator from ! to ~
Since the intent is
to reset the appropriate bit in ref_frame_flags not to
test a logic condition. Prior result would always have
been ref_frame_flags being set to 0.
(Issue reported by dgohman, issue 47)

Change-Id: I2c12502ed74c73cf38e98c9680e0249c29e16433
2010-06-21 15:23:51 +01:00
agrange
d4b99b8e3a Moved DOUBLE_DIVIDE_CHECK to denominator (was on numerator)
The DOUBLE_DIVIDE_CHECK macro prevents from divide by 0,
so must be on the denominator to work as intended.

Change-Id: Ie109242d52dbb9a2c4bc1e11890fa51b5f87ffc7
2010-06-21 15:20:52 +01:00
Timothy B. Terriberry
9f81463454 Fix a linker error on x86-64 Linux when not using a version script.
If the version script produced by the libvpx build system is not
 used when linking a shared library on x86-64 Linux, the constant
 data in the subpel filters produces R_X86_64_32 relocation errors
 due to the use of wrt rip addressing instead of
 wrt rip wrt ..gotpcrel.
Instead of adding a new macro for this addressing mode, this patch
 sets the ELF visibility of these symbols to "hidden", which
 allows wrt rip addressing to work without a text relocation.
This allows building a shared library without using the provided
 build system or a separate version script.
Fixes http://code.google.com/p/webm/issues/detail?id=46

Change-Id: Ie108f9d9a4352e5af46938bf4750d2302c1b2dc2
2010-06-21 08:19:12 -04:00
Jim Bankoski
220daa00e0 vp8_block_error_xmm: remove unnecessary instructions
Remove a couple instructions from this function which weren't
necessary for correct execution.

Change-Id: Ib649674f140689f7e5c1530c35686241688a3151
2010-06-18 13:34:43 -04:00
John Koleszar
94c52e4da8 cosmetics: trim trailing whitespace
When the license headers were updated, they accidentally contained
trailing whitespace, so unfortunately we have to touch all the files
again.

Change-Id: I236c05fade06589e417179c0444cb39b09e4200d
2010-06-18 13:06:11 -04:00
John Koleszar
c65e8e8e46 Merge "Change bitreader to use a larger window." 2010-06-17 18:08:36 -07:00
Timothy B. Terriberry
c17b62e1bd Change bitreader to use a larger window.
Change bitreading functions to use a larger window which is refilled less
 often.

This makes it cheap enough to do bounds checking each time the window is
 refilled, which avoids the need to copy the input into a large circular
 buffer.
This uses less memory and speeds up the total decode time by 1.6% on an ARM11,
 2.8% on a Cortex A8, and 2.2% on x86-32, but less than 1% on x86-64.

Inlining vp8dx_bool_decoder_fill() has a big penalty on x86-32, as does moving
 the refill loop to the front of vp8dx_decode_bool().
However, having the refill loop between computation of the split values and
 the branch in vp8_decode_mb_tokens() is a big win on ARM (presumably due to
 memory latency and code size: refilling after normalization duplicates the
 code in the DECODE_AND_BRANCH_IF_ZERO and DECODE_AND_LOOP_IF_ZERO cases.
Unfortunately, refilling at the end of vp8dx_bool_decoder_fill() and at the
 beginning of each decode step in vp8_decode_mb_tokens() means the latter
 requires an extra refill at the end.
Platform-specific versions could avoid the problem, but would require most of
 detokenize.c to be duplicated.

Change-Id: I16c782a63376f2a15b78f8086d899b987204c1c7
2010-06-15 19:55:14 -07:00
Yunqing Wang
9fdfb8e928 Merge "More on "some XMM registers are non-volatile on windows x64 ABI"" 2010-06-15 06:41:54 -07:00
Yunqing Wang
397aad3ec2 More on "some XMM registers are non-volatile on windows x64 ABI"
Add same fix in subpixel_sse2.asm.

Change-Id: Icfda6103cbf74ec43308e96961dd738aa823c14d
2010-06-15 09:11:26 -04:00
John Koleszar
89c8b3dbc6 vp8_cx_iface: set default cpu used to 0
Change-Id: I7b35f4717cdd204224112f72471b551617262417
2010-06-14 17:28:15 -04:00
Guillermo Ballester Valor
5a72620de9 Fix compiler warnings
Change-Id: I2a97f08cc3c7808ce5be39e910cc5147ecf03a1d
2010-06-14 17:23:49 -04:00
Scott LaVarnway
48c84d138f sse2 version of vp8_regular_quantize_b
Added sse2 version of vp8_regular_quantize_b which improved encode
performance(for the clip used) by ~10% for 32 bit builds and ~3% for
64 bit builds.

Also updated SHADOW_ARGS_TO_STACK to allow for more than 9 arguments.

Change-Id: I62f78eabc8040b39f3ffdf21be175811e96b39af
2010-06-14 14:07:56 -04:00
Paul Wilkins
99c5745760 Merge "Use local pointer to pbi->common." 2010-06-14 09:55:02 -07:00