Merge loop over all macroblock modes into encode_sb_row().

Rename pick_mb_modes to pick_mb_mode, since it now handles only a
single macroblock. This is consistent with pick_sb_mode handling a
single non-macroblock.

Change-Id: I896fdfa06436b2d8c24d6474718cc74420df6b3b

vp9/encoder/vp9_encodeframe.c

@@ -710,115 +710,65 @@ static void set_offsets(VP9_COMP *cpi,
 }
 
 static int pick_mb_modes(VP9_COMP *cpi,
-                         int mb_row0,
+                         int mb_row,
-                         int mb_col0,
+                         int mb_col,
                          TOKENEXTRA **tp,
                          int *totalrate,
                          int *totaldist) {
   VP9_COMMON *const cm = &cpi->common;
   MACROBLOCK *const x = &cpi->mb;
   MACROBLOCKD *const xd = &x->e_mbd;
-  int i;
   int splitmodes_used = 0;
-  ENTROPY_CONTEXT_PLANES left_context[2];
+  MB_MODE_INFO *mbmi;
-  ENTROPY_CONTEXT_PLANES above_context[2];
-  ENTROPY_CONTEXT_PLANES *initial_above_context_ptr = cm->above_context
-                                                      + mb_col0;
 
-  /* Function should not modify L & A contexts; save and restore on exit */
+  set_offsets(cpi, mb_row, mb_col, BLOCK_SIZE_MB16X16);
-  vpx_memcpy(left_context,
-             cm->left_context + (mb_row0 & 2),
-             sizeof(left_context));
-  vpx_memcpy(above_context,
-             initial_above_context_ptr,
-             sizeof(above_context));
 
-  /* Encode MBs in raster order within the SB */
+  if (cpi->oxcf.tuning == VP8_TUNE_SSIM)
-  for (i = 0; i < 4; i++) {
+    vp9_activity_masking(cpi, x);
-    const int x_idx = i & 1, y_idx = i >> 1;
-    const int mb_row = mb_row0 + y_idx;
-    const int mb_col = mb_col0 + x_idx;
-    MB_MODE_INFO *mbmi;
 
-    if ((mb_row >= cm->mb_rows) || (mb_col >= cm->mb_cols)) {
+  mbmi = &xd->mode_info_context->mbmi;
-      // MB lies outside frame, move on
+  mbmi->sb_type = BLOCK_SIZE_MB16X16;
-      continue;
+
+  // Find best coding mode & reconstruct the MB so it is available
+  // as a predictor for MBs that follow in the SB
+  if (cm->frame_type == KEY_FRAME) {
+    vp9_rd_pick_intra_mode(cpi, x, totalrate, totaldist);
+
+    // Save the coding context
+    vpx_memcpy(&x->mb_context[xd->sb_index][xd->mb_index].mic,
+               xd->mode_info_context, sizeof(MODE_INFO));
+
+    // Dummy encode, do not do the tokenization
+    encode_macroblock(cpi, tp, 0, mb_row, mb_col);
+  } else {
+    int seg_id;
+
+    vp9_pick_mode_inter_macroblock(cpi, x, mb_row, mb_col,
+                                   totalrate, totaldist);
+    splitmodes_used += (mbmi->mode == SPLITMV);
+
+    // Dummy encode, do not do the tokenization
+    encode_macroblock(cpi, tp, 0, mb_row, mb_col);
+
+    seg_id = mbmi->segment_id;
+    if (cpi->mb.e_mbd.segmentation_enabled && seg_id == 0) {
+      cpi->seg0_idx++;
     }
+    if (!xd->segmentation_enabled ||
+        !vp9_segfeature_active(xd, seg_id, SEG_LVL_REF_FRAME) ||
+        vp9_check_segref(xd, seg_id, INTRA_FRAME)  +
+        vp9_check_segref(xd, seg_id, LAST_FRAME)   +
+        vp9_check_segref(xd, seg_id, GOLDEN_FRAME) +
+        vp9_check_segref(xd, seg_id, ALTREF_FRAME) > 1) {
+      // Get the prediction context and status
+      int pred_flag = vp9_get_pred_flag(xd, PRED_REF);
+      int pred_context = vp9_get_pred_context(cm, xd, PRED_REF);
 
-    // Index of the MB in the SB 0..3
+      // Count prediction success
-    xd->mb_index = i;
+      cpi->ref_pred_count[pred_context][pred_flag]++;
-    set_offsets(cpi, mb_row, mb_col, BLOCK_SIZE_MB16X16);
-
-    if (cpi->oxcf.tuning == VP8_TUNE_SSIM)
-      vp9_activity_masking(cpi, x);
-
-    mbmi = &xd->mode_info_context->mbmi;
-    mbmi->sb_type = BLOCK_SIZE_MB16X16;
-
-    // Find best coding mode & reconstruct the MB so it is available
-    // as a predictor for MBs that follow in the SB
-    if (cm->frame_type == KEY_FRAME) {
-      int r, d;
-#if 0  // ENC_DEBUG
-      if (enc_debug)
-        printf("intra pick_mb_modes %d %d\n", mb_row, mb_col);
-#endif
-      vp9_rd_pick_intra_mode(cpi, x, &r, &d);
-      *totalrate += r;
-      *totaldist += d;
-
-      // Dummy encode, do not do the tokenization
-      encode_macroblock(cpi, tp, 0, mb_row, mb_col);
-
-      // Note the encoder may have changed the segment_id
-
-      // Save the coding context
-      vpx_memcpy(&x->mb_context[xd->sb_index][i].mic, xd->mode_info_context,
-                 sizeof(MODE_INFO));
-    } else {
-      int seg_id, r, d;
-
-#if 0  // ENC_DEBUG
-      if (enc_debug)
-        printf("inter pick_mb_modes %d %d\n", mb_row, mb_col);
-#endif
-      vp9_pick_mode_inter_macroblock(cpi, x, mb_row, mb_col, &r, &d);
-      *totalrate += r;
-      *totaldist += d;
-
-      splitmodes_used += (mbmi->mode == SPLITMV);
-
-      // Dummy encode, do not do the tokenization
-      encode_macroblock(cpi, tp, 0, mb_row, mb_col);
-
-      seg_id = mbmi->segment_id;
-      if (cpi->mb.e_mbd.segmentation_enabled && seg_id == 0) {
-        cpi->seg0_idx++;
-      }
-      if (!xd->segmentation_enabled ||
-          !vp9_segfeature_active(xd, seg_id, SEG_LVL_REF_FRAME) ||
-          vp9_check_segref(xd, seg_id, INTRA_FRAME)  +
-          vp9_check_segref(xd, seg_id, LAST_FRAME)   +
-          vp9_check_segref(xd, seg_id, GOLDEN_FRAME) +
-          vp9_check_segref(xd, seg_id, ALTREF_FRAME) > 1) {
-        // Get the prediction context and status
-        int pred_flag = vp9_get_pred_flag(xd, PRED_REF);
-        int pred_context = vp9_get_pred_context(cm, xd, PRED_REF);
-
-        // Count prediction success
-        cpi->ref_pred_count[pred_context][pred_flag]++;
-      }
     }
   }
 
-  /* Restore L & A coding context to those in place on entry */
-  vpx_memcpy(cm->left_context + (mb_row0 & 2),
-             left_context,
-             sizeof(left_context));
-  vpx_memcpy(initial_above_context_ptr,
-             above_context,
-             sizeof(above_context));
-
   return splitmodes_used;
 }
 
@@ -1038,14 +988,41 @@ static void encode_sb_row(VP9_COMP *cpi,
       int sb_rate = INT_MAX, sb_dist;
       int splitmodes_used = 0;
       int sb32_skip = 0;
+      int j;
+      ENTROPY_CONTEXT_PLANES l2[2], a2[2];
 
       if (mb_row + y_idx >= cm->mb_rows || mb_col + x_idx >= cm->mb_cols)
         continue;
 
       xd->sb_index = i;
 
-      splitmodes_used = pick_mb_modes(cpi, mb_row + y_idx, mb_col + x_idx,
+      /* Function should not modify L & A contexts; save and restore on exit */
-                                      tp, &mb_rate, &mb_dist);
+      vpx_memcpy(l2, cm->left_context + y_idx, sizeof(l2));
+      vpx_memcpy(a2, cm->above_context + mb_col + x_idx, sizeof(a2));
+
+      /* Encode MBs in raster order within the SB */
+      for (j = 0; j < 4; j++) {
+        const int x_idx_m = x_idx + (j & 1), y_idx_m = y_idx + (j >> 1);
+        int r, d;
+
+        if (mb_row + y_idx_m >= cm->mb_rows ||
+            mb_col + x_idx_m >= cm->mb_cols) {
+          // MB lies outside frame, move on
+          continue;
+        }
+
+        // Index of the MB in the SB 0..3
+        xd->mb_index = j;
+
+        splitmodes_used += pick_mb_modes(cpi, mb_row + y_idx_m,
+                                         mb_col + x_idx_m, tp, &r, &d);
+        mb_rate += r;
+        mb_dist += d;
+      }
+
+      /* Restore L & A coding context to those in place on entry */
+      vpx_memcpy(cm->left_context + y_idx, l2, sizeof(l2));
+      vpx_memcpy(cm->above_context + mb_col + x_idx, a2, sizeof(a2));
 
       mb_rate += vp9_cost_bit(cm->prob_sb32_coded, 0);