From e97804c67d2b1e35d2a3e3fd5d97d46e2fea97cd Mon Sep 17 00:00:00 2001 From: James Zern Date: Thu, 15 Mar 2018 21:43:29 +0000 Subject: [PATCH] Revert "vp9_loopfilter.c: zero lfl_uv" This reverts commit 13d0955b250bcb7eac99034e7b1677d3d026b569. Reason for revert: this should be investigated further to ensure the memset is really necessary outside of the static analysis pass. Original change's description: > vp9_loopfilter.c: zero lfl_uv > > The initialization depends on cm and mi_row which static > analysis does not approve of. > > Clears a static analysis warning: > warning: The right operand of '+' is a garbage value > const loop_filter_thresh *lfi = lfthr + *lfl; > > Change-Id: I8c863ced2b1e9a7e10103b7281098f20941a6ca2 TBR=johannkoenig@google.com,marpan@google.com,builds@webmproject.org,jianj@google.com Change-Id: Icadb6438fbcddba747622f06f2eadebdb333edf6 No-Presubmit: true No-Tree-Checks: true No-Try: true --- vp9/common/vp9_loopfilter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/vp9/common/vp9_loopfilter.c b/vp9/common/vp9_loopfilter.c index f51c8c46d..da9180b71 100644 --- a/vp9/common/vp9_loopfilter.c +++ b/vp9/common/vp9_loopfilter.c @@ -1330,7 +1330,6 @@ void vp9_filter_block_plane_ss11(VP9_COMMON *const cm, uint16_t mask_4x4 = lfm->left_uv[TX_4X4]; uint16_t mask_4x4_int = lfm->int_4x4_uv; - vp9_zero(lfl_uv); assert(plane->subsampling_x == 1 && plane->subsampling_y == 1); // Vertical pass: do 2 rows at one time