generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86inc.asm: only set visibility for chromium builds

Browse Source 
this restores the previous version's behavior avoiding issues with
builds that may split sources on directory boundaries; protected
visibility may work in this case.

Change-Id: Ie759bd96c9ea5b45613f450dffa6e67eb45f5a8b
This commit is contained in:
James Zern
2016-02-17 18:32:57 -08:00
committed by Johann
parent a97c83f7a4
commit a4b47b89fd
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
third_party/x86inc/README.libvpx vendored
View File

@@ -17,3 +17,4 @@ Set 'private_extern' visibility for macho targets.
Copy PIC 'GLOBAL' macros from x86_abi_support.asm Copy PIC 'GLOBAL' macros from x86_abi_support.asm
Use .text instead of .rodata on macho to avoid broken tables in PIC mode. Use .text instead of .rodata on macho to avoid broken tables in PIC mode.
Use .text with no alignment for aout Use .text with no alignment for aout
Only use 'hidden' visibility with Chromium

9
third_party/x86inc/x86inc.asm vendored
View File

@@ -786,7 +786,14 @@ BRANCH_INSTR jz, je, jnz, jne, jl, jle, jnl, jnle, jg, jge, jng, jnge, ja, jae,
annotate_function_size annotate_function_size
%if %1 %if %1
%xdefine %%FUNCTION_PREFIX private_prefix %xdefine %%FUNCTION_PREFIX private_prefix
%xdefine %%VISIBILITY hidden ; libvpx explicitly sets visibility in shared object builds. Avoid
; setting visibility to hidden as it may break builds that split
; sources on e.g., directory boundaries.
%ifdef CHROMIUM
%xdefine %%VISIBILITY hidden
%else
%xdefine %%VISIBILITY
%endif
%else %else
%xdefine %%FUNCTION_PREFIX public_prefix %xdefine %%FUNCTION_PREFIX public_prefix
%xdefine %%VISIBILITY %xdefine %%VISIBILITY