From d49da085c04a90d5ea74598fa2c26ac2c5356d71 Mon Sep 17 00:00:00 2001 From: Yaowu Xu Date: Tue, 16 Nov 2010 10:51:43 -0800 Subject: [PATCH 1/3] correct errors in token alphabet descriptions There were a few errors in the comment section that describe VP8 token alphabet table. Change-Id: Ie6728a0e08bc3798893221b60408d5b201064bdc --- vp8/common/entropy.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vp8/common/entropy.h b/vp8/common/entropy.h index 0685cd0ae..70e2ae675 100644 --- a/vp8/common/entropy.h +++ b/vp8/common/entropy.h @@ -24,10 +24,10 @@ #define FOUR_TOKEN 4 /* 4 Extra Bits 0+1 */ #define DCT_VAL_CATEGORY1 5 /* 5-6 Extra Bits 1+1 */ #define DCT_VAL_CATEGORY2 6 /* 7-10 Extra Bits 2+1 */ -#define DCT_VAL_CATEGORY3 7 /* 11-26 Extra Bits 4+1 */ -#define DCT_VAL_CATEGORY4 8 /* 11-26 Extra Bits 5+1 */ -#define DCT_VAL_CATEGORY5 9 /* 27-58 Extra Bits 5+1 */ -#define DCT_VAL_CATEGORY6 10 /* 59+ Extra Bits 11+1 */ +#define DCT_VAL_CATEGORY3 7 /* 11-18 Extra Bits 3+1 */ +#define DCT_VAL_CATEGORY4 8 /* 19-34 Extra Bits 4+1 */ +#define DCT_VAL_CATEGORY5 9 /* 35-66 Extra Bits 5+1 */ +#define DCT_VAL_CATEGORY6 10 /* 67+ Extra Bits 11+1 */ #define DCT_EOB_TOKEN 11 /* EOB Extra Bits 0+0 */ #define vp8_coef_tokens 12 From faaa57b945e05a29f2e423a810c0a39266533011 Mon Sep 17 00:00:00 2001 From: tomfinegan Date: Tue, 16 Nov 2010 14:52:05 -0500 Subject: [PATCH 2/3] Add x86_64-darwin10-gcc target. Adds native build configuration for Snow Leopard. Useful when users configure without arguments on OSX 10.6. Change-Id: I0bd63912a25bbfb9d4c8d58a781d0f390792429c --- build/make/configure.sh | 10 ++++++++++ configure | 1 + 2 files changed, 11 insertions(+) diff --git a/build/make/configure.sh b/build/make/configure.sh index d25d6400e..c5885da67 100755 --- a/build/make/configure.sh +++ b/build/make/configure.sh @@ -547,6 +547,10 @@ process_common_toolchain() { tgt_isa=universal tgt_os=darwin9 ;; + *darwin10*) + tgt_isa=x86_64 + tgt_os=darwin10 + ;; *mingw32*|*cygwin*) [ -z "$tgt_isa" ] && tgt_isa=x86 tgt_os=win32 @@ -606,6 +610,12 @@ process_common_toolchain() { add_ldflags "-isysroot /Developer/SDKs/MacOSX10.5.sdk" add_ldflags "-mmacosx-version-min=10.5" ;; + *-darwin10-*) + add_cflags "-isysroot /Developer/SDKs/MacOSX10.6.sdk" + add_cflags "-mmacosx-version-min=10.6" + add_ldflags "-isysroot /Developer/SDKs/MacOSX10.6.sdk" + add_ldflags "-mmacosx-version-min=10.6" + ;; esac # Handle Solaris variants. Solaris 10 needs -lposix4 diff --git a/configure b/configure index f32fffe38..5a502ae33 100755 --- a/configure +++ b/configure @@ -115,6 +115,7 @@ all_platforms="${all_platforms} x86-win32-vs7" all_platforms="${all_platforms} x86-win32-vs8" all_platforms="${all_platforms} x86-win32-vs9" all_platforms="${all_platforms} x86_64-darwin9-gcc" +all_platforms="${all_platforms} x86_64-darwin10-gcc" all_platforms="${all_platforms} x86_64-linux-gcc" all_platforms="${all_platforms} x86_64-linux-icc" all_platforms="${all_platforms} x86_64-solaris-gcc" From 69ee697feff0e7fcb3b60069f8005cd3e3f35169 Mon Sep 17 00:00:00 2001 From: Fritz Koenig Date: Tue, 16 Nov 2010 15:16:24 -0800 Subject: [PATCH 3/3] Comments for alt ref flags. Clarify what the alt ref flags do when encoding. Change-Id: I71f78e0f42edae633fb91840f29dfbe64362c44c --- vp8/encoder/onyx_int.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/vp8/encoder/onyx_int.h b/vp8/encoder/onyx_int.h index a9eedf399..b3a09ec1b 100644 --- a/vp8/encoder/onyx_int.h +++ b/vp8/encoder/onyx_int.h @@ -278,14 +278,14 @@ typedef struct unsigned int source_frame_flags; YV12_BUFFER_CONFIG scaled_source; - int source_buffer_count; - int source_encode_index; - int source_alt_ref_pending; - int source_alt_ref_active; + int source_buffer_count; // number of src_buffers in use for lagged encoding + int source_encode_index; // index of buffer in src_buffer to encode + int source_alt_ref_pending; // frame in src_buffers has been identified to be encoded as an alt ref + int source_alt_ref_active; // an alt ref frame has been encoded and is usable - int last_alt_ref_sei; - int is_src_frame_alt_ref; - int is_next_src_alt_ref; + int last_alt_ref_sei; // index into src_buffers of frame used as alt reference + int is_src_frame_alt_ref; // source of frame to encode is an exact copy of an alt ref frame + int is_next_src_alt_ref; // source of next frame to encode is an exact copy of an alt ref frame int gold_is_last; // golden frame same as last frame ( short circuit gold searches) int alt_is_last; // Alt reference frame same as last ( short circuit altref search)