generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "vp9 com/dec: avoid reading unavailable above/left"

Browse Source
This commit is contained in:
James Zern
2013-10-18 13:22:19 -07:00
committed by Gerrit Code Review
parent db1045f2c0 67e41fe2f6
commit 68573c9d2b
3 changed files with 78 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

96
vp9/common/vp9_pred_common.c
View File

@@ -16,12 +16,20 @@
#include "vp9/common/vp9_seg_common.h" #include "vp9/common/vp9_seg_common.h"
#include "vp9/common/vp9_treecoder.h" #include "vp9/common/vp9_treecoder.h"
static INLINE const MB_MODE_INFO *get_above_mbmi(const MODE_INFO *const above) {
return (above != NULL) ? &above->mbmi : NULL;
}
static INLINE const MB_MODE_INFO *get_left_mbmi(const MODE_INFO *const left) {
return (left != NULL) ? &left->mbmi : NULL;
}
// Returns a context number for the given MB prediction signal // Returns a context number for the given MB prediction signal
unsigned char vp9_get_pred_context_switchable_interp(const MACROBLOCKD *xd) { unsigned char vp9_get_pred_context_switchable_interp(const MACROBLOCKD *xd) {
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
// Note: // Note:
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
// left of the entries correpsonding to real macroblocks. // left of the entries correpsonding to real macroblocks.
@@ -53,14 +61,14 @@ unsigned char vp9_get_pred_context_switchable_interp(const MACROBLOCKD *xd) {
} }
// Returns a context number for the given MB prediction signal // Returns a context number for the given MB prediction signal
unsigned char vp9_get_pred_context_intra_inter(const MACROBLOCKD *xd) { unsigned char vp9_get_pred_context_intra_inter(const MACROBLOCKD *xd) {
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1; const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
// left of the entries corresponding to real macroblocks. // left of the entries corresponding to real macroblocks.
@@ -81,12 +89,12 @@ unsigned char vp9_get_pred_context_intra_inter(const MACROBLOCKD *xd) {
unsigned char vp9_get_pred_context_comp_inter_inter(const VP9_COMMON *cm, unsigned char vp9_get_pred_context_comp_inter_inter(const VP9_COMMON *cm,
const MACROBLOCKD *xd) { const MACROBLOCKD *xd) {
int pred_context; int pred_context;
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
// Note: // Note:
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
// left of the entries correpsonding to real macroblocks. // left of the entries correpsonding to real macroblocks.
@@ -126,14 +134,14 @@ unsigned char vp9_get_pred_context_comp_inter_inter(const VP9_COMMON *cm,
unsigned char vp9_get_pred_context_comp_ref_p(const VP9_COMMON *cm, unsigned char vp9_get_pred_context_comp_ref_p(const VP9_COMMON *cm,
const MACROBLOCKD *xd) { const MACROBLOCKD *xd) {
int pred_context; int pred_context;
const MODE_INFO * const above_mi = xd->mi_8x8[-cm->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1; const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
// Note: // Note:
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
// left of the entries correpsonding to real macroblocks. // left of the entries correpsonding to real macroblocks.
@@ -206,14 +214,14 @@ unsigned char vp9_get_pred_context_comp_ref_p(const VP9_COMMON *cm,
} }
unsigned char vp9_get_pred_context_single_ref_p1(const MACROBLOCKD *xd) { unsigned char vp9_get_pred_context_single_ref_p1(const MACROBLOCKD *xd) {
int pred_context; int pred_context;
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1; const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
// Note: // Note:
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
// left of the entries correpsonding to real macroblocks. // left of the entries correpsonding to real macroblocks.
@@ -272,14 +280,14 @@ unsigned char vp9_get_pred_context_single_ref_p1(const MACROBLOCKD *xd) {
unsigned char vp9_get_pred_context_single_ref_p2(const MACROBLOCKD *xd) { unsigned char vp9_get_pred_context_single_ref_p2(const MACROBLOCKD *xd) {
int pred_context; int pred_context;
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1; const int above_intra = above_in_image ? !is_inter_block(above_mbmi) : 1;
const int left_intra = left_in_image ? !is_inter_block(left_mbmi) : 1;
// Note: // Note:
// The mode info data structure has a one element border above and to the // The mode info data structure has a one element border above and to the
@@ -361,12 +369,12 @@ unsigned char vp9_get_pred_context_single_ref_p2(const MACROBLOCKD *xd) {
// left of the entries corresponding to real blocks. // left of the entries corresponding to real blocks.
// The prediction flags in these dummy entries are initialized to 0. // The prediction flags in these dummy entries are initialized to 0.
unsigned char vp9_get_pred_context_tx_size(const MACROBLOCKD *xd) { unsigned char vp9_get_pred_context_tx_size(const MACROBLOCKD *xd) {
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const MB_MODE_INFO *const above_mbmi = above_mi ? &above_mi->mbmi : 0; const MB_MODE_INFO *const above_mbmi = get_above_mbmi(above_mi);
const MB_MODE_INFO *const left_mbmi = left_mi ? &left_mi->mbmi : 0; const MB_MODE_INFO *const left_mbmi = get_left_mbmi(left_mi);
const int left_in_image = xd->left_available && left_mi; const int above_in_image = above_mi != NULL;
const int above_in_image = xd->up_available && above_mi; const int left_in_image = left_mi != NULL;
const int max_tx_size = max_txsize_lookup[xd->mi_8x8[0]->mbmi.sb_type]; const int max_tx_size = max_txsize_lookup[xd->mi_8x8[0]->mbmi.sb_type];
int above_context = max_tx_size; int above_context = max_tx_size;
int left_context = max_tx_size; int left_context = max_tx_size;

31
vp9/common/vp9_pred_common.h
View File

@@ -14,17 +14,25 @@
#include "vp9/common/vp9_blockd.h" #include "vp9/common/vp9_blockd.h"
#include "vp9/common/vp9_onyxc_int.h" #include "vp9/common/vp9_onyxc_int.h"
static INLINE const MODE_INFO *get_above_mi(const MACROBLOCKD *const xd) {
return xd->up_available ? xd->mi_8x8[-xd->mode_info_stride] : NULL;
}
static INLINE const MODE_INFO *get_left_mi(const MACROBLOCKD *const xd) {
return xd->left_available ? xd->mi_8x8[-1] : NULL;
}
int vp9_get_segment_id(VP9_COMMON *cm, const uint8_t *segment_ids, int vp9_get_segment_id(VP9_COMMON *cm, const uint8_t *segment_ids,
BLOCK_SIZE bsize, int mi_row, int mi_col); BLOCK_SIZE bsize, int mi_row, int mi_col);
static INLINE int vp9_get_pred_context_seg_id(const MACROBLOCKD *xd) { static INLINE int vp9_get_pred_context_seg_id(const MACROBLOCKD *xd) {
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const int above_sip = above_mi ? above_mi->mbmi.seg_id_predicted : 0; const int above_sip = (above_mi != NULL) ?
const int left_sip = left_mi ? left_mi->mbmi.seg_id_predicted : 0; above_mi->mbmi.seg_id_predicted : 0;
const int left_sip = (left_mi != NULL) ? left_mi->mbmi.seg_id_predicted : 0;
return above_sip + (xd->left_available ? left_sip : 0); return above_sip + left_sip;
} }
static INLINE vp9_prob vp9_get_pred_prob_seg_id(struct segmentation *seg, static INLINE vp9_prob vp9_get_pred_prob_seg_id(struct segmentation *seg,
@@ -35,12 +43,13 @@ static INLINE vp9_prob vp9_get_pred_prob_seg_id(struct segmentation *seg,
void vp9_set_pred_flag_seg_id(MACROBLOCKD *xd, uint8_t pred_flag); void vp9_set_pred_flag_seg_id(MACROBLOCKD *xd, uint8_t pred_flag);
static INLINE int vp9_get_pred_context_mbskip(const MACROBLOCKD *xd) { static INLINE int vp9_get_pred_context_mbskip(const MACROBLOCKD *xd) {
const MODE_INFO * const above_mi = xd->mi_8x8[-xd->mode_info_stride]; const MODE_INFO *const above_mi = get_above_mi(xd);
const MODE_INFO * const left_mi = xd->mi_8x8[-1]; const MODE_INFO *const left_mi = get_left_mi(xd);
const int above_skip_coeff = above_mi ? above_mi->mbmi.skip_coeff : 0; const int above_skip_coeff = (above_mi != NULL) ?
const int left_skip_coeff = left_mi ? left_mi->mbmi.skip_coeff : 0; above_mi->mbmi.skip_coeff : 0;
const int left_skip_coeff = (left_mi != NULL) ? left_mi->mbmi.skip_coeff : 0;
return above_skip_coeff + (xd->left_available ? left_skip_coeff : 0); return above_skip_coeff + left_skip_coeff;
} }
static INLINE vp9_prob vp9_get_pred_prob_mbskip(const VP9_COMMON *cm, static INLINE vp9_prob vp9_get_pred_prob_mbskip(const VP9_COMMON *cm,

11
vp9/decoder/vp9_decodemv.c
View File

@@ -169,7 +169,6 @@ static void read_intra_frame_mode_info(VP9D_COMP *pbi, MODE_INFO *m,
MB_MODE_INFO *const mbmi = &m->mbmi; MB_MODE_INFO *const mbmi = &m->mbmi;
const BLOCK_SIZE bsize = mbmi->sb_type; const BLOCK_SIZE bsize = mbmi->sb_type;
const MODE_INFO *above_mi = xd->mi_8x8[-cm->mode_info_stride]; const MODE_INFO *above_mi = xd->mi_8x8[-cm->mode_info_stride];
const MODE_INFO *left_mi = xd->mi_8x8[-1];
mbmi->segment_id = read_intra_segment_id(pbi, mi_row, mi_col, r); mbmi->segment_id = read_intra_segment_id(pbi, mi_row, mi_col, r);
mbmi->skip_coeff = read_skip_coeff(pbi, mbmi->segment_id, r); mbmi->skip_coeff = read_skip_coeff(pbi, mbmi->segment_id, r);
@@ -179,8 +178,9 @@ static void read_intra_frame_mode_info(VP9D_COMP *pbi, MODE_INFO *m,
if (bsize >= BLOCK_8X8) { if (bsize >= BLOCK_8X8) {
const MB_PREDICTION_MODE A = above_block_mode(m, above_mi, 0); const MB_PREDICTION_MODE A = above_block_mode(m, above_mi, 0);
const MB_PREDICTION_MODE L = xd->left_available ? const MB_PREDICTION_MODE L = xd->left_available
left_block_mode(m, left_mi, 0) : DC_PRED; ? left_block_mode(m, xd->mi_8x8[-1], 0)
: DC_PRED;
mbmi->mode = read_intra_mode(r, vp9_kf_y_mode_prob[A][L]); mbmi->mode = read_intra_mode(r, vp9_kf_y_mode_prob[A][L]);
} else { } else {
// Only 4x4, 4x8, 8x4 blocks // Only 4x4, 4x8, 8x4 blocks
@@ -192,8 +192,9 @@ static void read_intra_frame_mode_info(VP9D_COMP *pbi, MODE_INFO *m,
for (idx = 0; idx < 2; idx += num_4x4_w) { for (idx = 0; idx < 2; idx += num_4x4_w) {
const int ib = idy * 2 + idx; const int ib = idy * 2 + idx;
const MB_PREDICTION_MODE A = above_block_mode(m, above_mi, ib); const MB_PREDICTION_MODE A = above_block_mode(m, above_mi, ib);
const MB_PREDICTION_MODE L = (xd->left_available || idx) ? const MB_PREDICTION_MODE L = (xd->left_available || idx)
left_block_mode(m, left_mi, ib) : DC_PRED; ? left_block_mode(m, xd->mi_8x8[-1], ib)
: DC_PRED;
const MB_PREDICTION_MODE b_mode = read_intra_mode(r, const MB_PREDICTION_MODE b_mode = read_intra_mode(r,
vp9_kf_y_mode_prob[A][L]); vp9_kf_y_mode_prob[A][L]);
m->bmi[ib].as_mode = b_mode; m->bmi[ib].as_mode = b_mode;