generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

vp9_dthread: interleave mutex/cond alloc+init

Browse Source 
this ensures both are properly initialized when calling _dealloc().
+ check the arrays before access

Change-Id: I789af39b41c271b5cb3c029526581b4d9903b895
This commit is contained in:
James Zern 2014-02-05 23:19:26 -08:00
parent 9602ed8808
commit 4e44457b4d
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
vp9/decoder/vp9_dthread.c
View File

@ -220,11 +220,13 @@ void vp9_loop_filter_alloc(VP9_COMMON *cm, VP9LfSync *lf_sync, int rows,
CHECK_MEM_ERROR(cm, lf_sync->mutex_,
vpx_malloc(sizeof(*lf_sync->mutex_) * rows));
CHECK_MEM_ERROR(cm, lf_sync->cond_,
vpx_malloc(sizeof(*lf_sync->cond_) * rows));
for (i = 0; i < rows; ++i) {
pthread_mutex_init(&lf_sync->mutex_[i], NULL);
}
CHECK_MEM_ERROR(cm, lf_sync->cond_,
vpx_malloc(sizeof(*lf_sync->cond_) * rows));
for (i = 0; i < rows; ++i) {
pthread_cond_init(&lf_sync->cond_[i], NULL);
}
#endif // CONFIG_MULTITHREAD
@ -242,18 +244,29 @@ void vp9_loop_filter_dealloc(VP9LfSync *lf_sync, int rows) {
if (lf_sync != NULL) {
int i;
for (i = 0; i < rows; ++i) {
pthread_mutex_destroy(&lf_sync->mutex_[i]);
pthread_cond_destroy(&lf_sync->cond_[i]);
if (lf_sync->mutex_ != NULL) {
for (i = 0; i < rows; ++i) {
pthread_mutex_destroy(&lf_sync->mutex_[i]);
}
vpx_free(lf_sync->mutex_);
}
if (lf_sync->cond_ != NULL) {
for (i = 0; i < rows; ++i) {
pthread_cond_destroy(&lf_sync->cond_[i]);
}
vpx_free(lf_sync->cond_);
}
vpx_free(lf_sync->mutex_);
vpx_free(lf_sync->cond_);
vpx_free(lf_sync->cur_sb_col);
// clear the structure as the source of this call may be a resize in which
// case this call will be followed by an _alloc() which may fail.
vpx_memset(lf_sync, 0, sizeof(*lf_sync));
}
#else
(void)rows;
if (lf_sync != NULL)
if (lf_sync != NULL) {
vpx_free(lf_sync->cur_sb_col);
vpx_memset(lf_sync, 0, sizeof(*lf_sync));
}
#endif // CONFIG_MULTITHREAD
}