From 3c18acf45234ea801b5f966467c6837e442ef4c0 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 08:03:45 -0700 Subject: [PATCH 1/6] sad neon: macroize 16xN definitions Change-Id: I5aea6ffbfa48eb1970afe3be54f0bba275d7fa58 --- vpx_dsp/arm/sad_neon.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index baaaf6378..170cd9f96 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -151,23 +151,16 @@ static INLINE uint16x8_t sad16x(const uint8_t *a, int a_stride, return abs; } -uint32_t vpx_sad16x8_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad16x(src, src_stride, ref, ref_stride, 8); - return horizontal_add_16x8(abs); -} +#define sad16xN(n) \ + uint32_t vpx_sad16x##n##_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride) { \ + const uint16x8_t abs = sad16x(src, src_stride, ref, ref_stride, n); \ + return horizontal_add_16x8(abs); \ + } -uint32_t vpx_sad16x16_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad16x(src, src_stride, ref, ref_stride, 16); - return horizontal_add_16x8(abs); -} - -uint32_t vpx_sad16x32_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad16x(src, src_stride, ref, ref_stride, 32); - return horizontal_add_16x8(abs); -} +sad16xN(8); +sad16xN(16); +sad16xN(32); static INLINE uint16x8_t sad32x(const uint8_t *a, int a_stride, const uint8_t *b, int b_stride, From 527e0c9b1c898360bb3cbf7cc7478a27395dbe58 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 08:31:41 -0700 Subject: [PATCH 2/6] sad neon: avg for 16x[8,16,32] BUG=webm:1425 Change-Id: Ia42e4f36547c5fe12114fb58379e34bce82eb2f2 --- test/sad_test.cc | 3 +++ vpx_dsp/arm/sad_neon.c | 28 ++++++++++++++++++++++++++++ vpx_dsp/vpx_dsp_rtcd_defs.pl | 6 +++--- 3 files changed, 34 insertions(+), 3 deletions(-) diff --git a/test/sad_test.cc b/test/sad_test.cc index 3df430504..2f3def819 100644 --- a/test/sad_test.cc +++ b/test/sad_test.cc @@ -658,6 +658,9 @@ const SadMxNParam neon_tests[] = { INSTANTIATE_TEST_CASE_P(NEON, SADTest, ::testing::ValuesIn(neon_tests)); const SadMxNAvgParam avg_neon_tests[] = { + SadMxNAvgParam(16, 32, &vpx_sad16x32_avg_neon), + SadMxNAvgParam(16, 16, &vpx_sad16x16_avg_neon), + SadMxNAvgParam(16, 8, &vpx_sad16x8_avg_neon), SadMxNAvgParam(8, 16, &vpx_sad8x16_avg_neon), SadMxNAvgParam(8, 8, &vpx_sad8x8_avg_neon), SadMxNAvgParam(8, 4, &vpx_sad8x4_avg_neon), diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index 170cd9f96..9951b92da 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -151,11 +151,39 @@ static INLINE uint16x8_t sad16x(const uint8_t *a, int a_stride, return abs; } +static INLINE uint16x8_t sad16x_avg(const uint8_t *a, int a_stride, + const uint8_t *b, int b_stride, + const uint8_t *c, const int height) { + int i; + uint16x8_t abs = vdupq_n_u16(0); + + for (i = 0; i < height; ++i) { + const uint8x16_t a_u8 = vld1q_u8(a); + const uint8x16_t b_u8 = vld1q_u8(b); + const uint8x16_t c_u8 = vld1q_u8(c); + const uint8x16_t avg = vrhaddq_u8(b_u8, c_u8); + a += a_stride; + b += b_stride; + c += 16; + abs = vabal_u8(abs, vget_low_u8(a_u8), vget_low_u8(avg)); + abs = vabal_u8(abs, vget_high_u8(a_u8), vget_high_u8(avg)); + } + return abs; +} + #define sad16xN(n) \ uint32_t vpx_sad16x##n##_neon(const uint8_t *src, int src_stride, \ const uint8_t *ref, int ref_stride) { \ const uint16x8_t abs = sad16x(src, src_stride, ref, ref_stride, n); \ return horizontal_add_16x8(abs); \ + } \ + \ + uint32_t vpx_sad16x##n##_avg_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride, \ + const uint8_t *second_pred) { \ + const uint16x8_t abs = \ + sad16x_avg(src, src_stride, ref, ref_stride, second_pred, n); \ + return horizontal_add_16x8(abs); \ } sad16xN(8); diff --git a/vpx_dsp/vpx_dsp_rtcd_defs.pl b/vpx_dsp/vpx_dsp_rtcd_defs.pl index d2ebaa975..4da050e76 100644 --- a/vpx_dsp/vpx_dsp_rtcd_defs.pl +++ b/vpx_dsp/vpx_dsp_rtcd_defs.pl @@ -795,13 +795,13 @@ add_proto qw/unsigned int vpx_sad32x16_avg/, "const uint8_t *src_ptr, int src_st specialize qw/vpx_sad32x16_avg avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad16x32_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad16x32_avg msa sse2 vsx/; +specialize qw/vpx_sad16x32_avg neon msa sse2 vsx/; add_proto qw/unsigned int vpx_sad16x16_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad16x16_avg msa sse2 vsx/; +specialize qw/vpx_sad16x16_avg neon msa sse2 vsx/; add_proto qw/unsigned int vpx_sad16x8_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad16x8_avg msa sse2 vsx/; +specialize qw/vpx_sad16x8_avg neon msa sse2 vsx/; add_proto qw/unsigned int vpx_sad8x16_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; specialize qw/vpx_sad8x16_avg neon msa sse2/; From b0d15713beb8559d76eee9bf5c86ab70edbcdff4 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 08:33:15 -0700 Subject: [PATCH 3/6] sad neon: macroize 32xN definitions Change-Id: I0020a49e77d27514375a03095d5821dc0aa7d128 --- vpx_dsp/arm/sad_neon.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index 9951b92da..75352ef96 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -211,23 +211,16 @@ static INLINE uint16x8_t sad32x(const uint8_t *a, int a_stride, return abs; } -uint32_t vpx_sad32x16_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad32x(src, src_stride, ref, ref_stride, 16); - return horizontal_add_16x8(abs); -} +#define sad32xN(n) \ + uint32_t vpx_sad32x##n##_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride) { \ + const uint16x8_t abs = sad32x(src, src_stride, ref, ref_stride, n); \ + return horizontal_add_16x8(abs); \ + } -uint32_t vpx_sad32x32_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad32x(src, src_stride, ref, ref_stride, 32); - return horizontal_add_16x8(abs); -} - -uint32_t vpx_sad32x64_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint16x8_t abs = sad32x(src, src_stride, ref, ref_stride, 64); - return horizontal_add_16x8(abs); -} +sad32xN(16); +sad32xN(32); +sad32xN(64); static INLINE uint32_t horizontal_add_32x4(const uint32x4_t a) { const uint64x2_t b = vpaddlq_u32(a); From 67cffc1ef6cd15eaf8e4b319a7308d351c9d8177 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 08:55:05 -0700 Subject: [PATCH 4/6] sad neon: avg for 32x[16,32,64] BUG=webm:1425 Change-Id: I3362e0dded3b46ca032caa7f44db42f324bc596d --- test/sad_test.cc | 3 +++ vpx_dsp/arm/sad_neon.c | 34 ++++++++++++++++++++++++++++++++++ vpx_dsp/vpx_dsp_rtcd_defs.pl | 6 +++--- 3 files changed, 40 insertions(+), 3 deletions(-) diff --git a/test/sad_test.cc b/test/sad_test.cc index 2f3def819..0d0e6fa8c 100644 --- a/test/sad_test.cc +++ b/test/sad_test.cc @@ -658,6 +658,9 @@ const SadMxNParam neon_tests[] = { INSTANTIATE_TEST_CASE_P(NEON, SADTest, ::testing::ValuesIn(neon_tests)); const SadMxNAvgParam avg_neon_tests[] = { + SadMxNAvgParam(32, 64, &vpx_sad32x64_avg_neon), + SadMxNAvgParam(32, 32, &vpx_sad32x32_avg_neon), + SadMxNAvgParam(32, 16, &vpx_sad32x16_avg_neon), SadMxNAvgParam(16, 32, &vpx_sad16x32_avg_neon), SadMxNAvgParam(16, 16, &vpx_sad16x16_avg_neon), SadMxNAvgParam(16, 8, &vpx_sad16x8_avg_neon), diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index 75352ef96..0c31a620b 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -211,11 +211,45 @@ static INLINE uint16x8_t sad32x(const uint8_t *a, int a_stride, return abs; } +static INLINE uint16x8_t sad32x_avg(const uint8_t *a, int a_stride, + const uint8_t *b, int b_stride, + const uint8_t *c, const int height) { + int i; + uint16x8_t abs = vdupq_n_u16(0); + + for (i = 0; i < height; ++i) { + const uint8x16_t a_lo = vld1q_u8(a); + const uint8x16_t a_hi = vld1q_u8(a + 16); + const uint8x16_t b_lo = vld1q_u8(b); + const uint8x16_t b_hi = vld1q_u8(b + 16); + const uint8x16_t c_lo = vld1q_u8(c); + const uint8x16_t c_hi = vld1q_u8(c + 16); + const uint8x16_t avg_lo = vrhaddq_u8(b_lo, c_lo); + const uint8x16_t avg_hi = vrhaddq_u8(b_hi, c_hi); + a += a_stride; + b += b_stride; + c += 32; + abs = vabal_u8(abs, vget_low_u8(a_lo), vget_low_u8(avg_lo)); + abs = vabal_u8(abs, vget_high_u8(a_lo), vget_high_u8(avg_lo)); + abs = vabal_u8(abs, vget_low_u8(a_hi), vget_low_u8(avg_hi)); + abs = vabal_u8(abs, vget_high_u8(a_hi), vget_high_u8(avg_hi)); + } + return abs; +} + #define sad32xN(n) \ uint32_t vpx_sad32x##n##_neon(const uint8_t *src, int src_stride, \ const uint8_t *ref, int ref_stride) { \ const uint16x8_t abs = sad32x(src, src_stride, ref, ref_stride, n); \ return horizontal_add_16x8(abs); \ + } \ + \ + uint32_t vpx_sad32x##n##_avg_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride, \ + const uint8_t *second_pred) { \ + const uint16x8_t abs = \ + sad32x_avg(src, src_stride, ref, ref_stride, second_pred, n); \ + return horizontal_add_16x8(abs); \ } sad32xN(16); diff --git a/vpx_dsp/vpx_dsp_rtcd_defs.pl b/vpx_dsp/vpx_dsp_rtcd_defs.pl index 4da050e76..e3a42d067 100644 --- a/vpx_dsp/vpx_dsp_rtcd_defs.pl +++ b/vpx_dsp/vpx_dsp_rtcd_defs.pl @@ -786,13 +786,13 @@ add_proto qw/unsigned int vpx_sad64x32_avg/, "const uint8_t *src_ptr, int src_st specialize qw/vpx_sad64x32_avg avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad32x64_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad32x64_avg avx2 msa sse2 vsx/; +specialize qw/vpx_sad32x64_avg neon avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad32x32_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad32x32_avg avx2 msa sse2 vsx/; +specialize qw/vpx_sad32x32_avg neon avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad32x16_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad32x16_avg avx2 msa sse2 vsx/; +specialize qw/vpx_sad32x16_avg neon avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad16x32_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; specialize qw/vpx_sad16x32_avg neon msa sse2 vsx/; From 6ae8f8dbe80b4b8dce1ac010e34d7f2ee0ade55d Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 08:58:06 -0700 Subject: [PATCH 5/6] sad neon: macroize 64xN definitions Change-Id: Iaa6ea75b10e75784f31b1e08637eecf0dcb5cff9 --- vpx_dsp/arm/sad_neon.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index 0c31a620b..787ad0d42 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -297,14 +297,12 @@ static INLINE uint32x4_t sad64x(const uint8_t *a, int a_stride, } } -uint32_t vpx_sad64x32_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint32x4_t abs = sad64x(src, src_stride, ref, ref_stride, 32); - return horizontal_add_32x4(abs); -} +#define sad64xN(n) \ + uint32_t vpx_sad64x##n##_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride) { \ + const uint32x4_t abs = sad64x(src, src_stride, ref, ref_stride, n); \ + return horizontal_add_32x4(abs); \ + } -uint32_t vpx_sad64x64_neon(const uint8_t *src, int src_stride, - const uint8_t *ref, int ref_stride) { - const uint32x4_t abs = sad64x(src, src_stride, ref, ref_stride, 64); - return horizontal_add_32x4(abs); -} +sad64xN(32); +sad64xN(64); From e4e08556db4f964bc44f3c4fdb3af8898dcb8522 Mon Sep 17 00:00:00 2001 From: Johann Date: Thu, 6 Jul 2017 09:16:02 -0700 Subject: [PATCH 6/6] sad neon: avg for 64x[32,64] BUG=webm:1425 Change-Id: Id84d97807a6a0fbcc889c4dfe11929d54f85493d --- test/sad_test.cc | 2 ++ vpx_dsp/arm/sad_neon.c | 51 ++++++++++++++++++++++++++++++++++++ vpx_dsp/vpx_dsp_rtcd_defs.pl | 4 +-- 3 files changed, 55 insertions(+), 2 deletions(-) diff --git a/test/sad_test.cc b/test/sad_test.cc index 0d0e6fa8c..ef8b01cae 100644 --- a/test/sad_test.cc +++ b/test/sad_test.cc @@ -658,6 +658,8 @@ const SadMxNParam neon_tests[] = { INSTANTIATE_TEST_CASE_P(NEON, SADTest, ::testing::ValuesIn(neon_tests)); const SadMxNAvgParam avg_neon_tests[] = { + SadMxNAvgParam(64, 64, &vpx_sad64x64_avg_neon), + SadMxNAvgParam(64, 32, &vpx_sad64x32_avg_neon), SadMxNAvgParam(32, 64, &vpx_sad32x64_avg_neon), SadMxNAvgParam(32, 32, &vpx_sad32x32_avg_neon), SadMxNAvgParam(32, 16, &vpx_sad32x16_avg_neon), diff --git a/vpx_dsp/arm/sad_neon.c b/vpx_dsp/arm/sad_neon.c index 787ad0d42..e651f7e66 100644 --- a/vpx_dsp/arm/sad_neon.c +++ b/vpx_dsp/arm/sad_neon.c @@ -297,11 +297,62 @@ static INLINE uint32x4_t sad64x(const uint8_t *a, int a_stride, } } +static INLINE uint32x4_t sad64x_avg(const uint8_t *a, int a_stride, + const uint8_t *b, int b_stride, + const uint8_t *c, const int height) { + int i; + uint16x8_t abs_0 = vdupq_n_u16(0); + uint16x8_t abs_1 = vdupq_n_u16(0); + + for (i = 0; i < height; ++i) { + const uint8x16_t a_0 = vld1q_u8(a); + const uint8x16_t a_1 = vld1q_u8(a + 16); + const uint8x16_t a_2 = vld1q_u8(a + 32); + const uint8x16_t a_3 = vld1q_u8(a + 48); + const uint8x16_t b_0 = vld1q_u8(b); + const uint8x16_t b_1 = vld1q_u8(b + 16); + const uint8x16_t b_2 = vld1q_u8(b + 32); + const uint8x16_t b_3 = vld1q_u8(b + 48); + const uint8x16_t c_0 = vld1q_u8(c); + const uint8x16_t c_1 = vld1q_u8(c + 16); + const uint8x16_t c_2 = vld1q_u8(c + 32); + const uint8x16_t c_3 = vld1q_u8(c + 48); + const uint8x16_t avg_0 = vrhaddq_u8(b_0, c_0); + const uint8x16_t avg_1 = vrhaddq_u8(b_1, c_1); + const uint8x16_t avg_2 = vrhaddq_u8(b_2, c_2); + const uint8x16_t avg_3 = vrhaddq_u8(b_3, c_3); + a += a_stride; + b += b_stride; + c += 64; + abs_0 = vabal_u8(abs_0, vget_low_u8(a_0), vget_low_u8(avg_0)); + abs_0 = vabal_u8(abs_0, vget_high_u8(a_0), vget_high_u8(avg_0)); + abs_0 = vabal_u8(abs_0, vget_low_u8(a_1), vget_low_u8(avg_1)); + abs_0 = vabal_u8(abs_0, vget_high_u8(a_1), vget_high_u8(avg_1)); + abs_1 = vabal_u8(abs_1, vget_low_u8(a_2), vget_low_u8(avg_2)); + abs_1 = vabal_u8(abs_1, vget_high_u8(a_2), vget_high_u8(avg_2)); + abs_1 = vabal_u8(abs_1, vget_low_u8(a_3), vget_low_u8(avg_3)); + abs_1 = vabal_u8(abs_1, vget_high_u8(a_3), vget_high_u8(avg_3)); + } + + { + const uint32x4_t sum = vpaddlq_u16(abs_0); + return vpadalq_u16(sum, abs_1); + } +} + #define sad64xN(n) \ uint32_t vpx_sad64x##n##_neon(const uint8_t *src, int src_stride, \ const uint8_t *ref, int ref_stride) { \ const uint32x4_t abs = sad64x(src, src_stride, ref, ref_stride, n); \ return horizontal_add_32x4(abs); \ + } \ + \ + uint32_t vpx_sad64x##n##_avg_neon(const uint8_t *src, int src_stride, \ + const uint8_t *ref, int ref_stride, \ + const uint8_t *second_pred) { \ + const uint32x4_t abs = \ + sad64x_avg(src, src_stride, ref, ref_stride, second_pred, n); \ + return horizontal_add_32x4(abs); \ } sad64xN(32); diff --git a/vpx_dsp/vpx_dsp_rtcd_defs.pl b/vpx_dsp/vpx_dsp_rtcd_defs.pl index e3a42d067..7459aa837 100644 --- a/vpx_dsp/vpx_dsp_rtcd_defs.pl +++ b/vpx_dsp/vpx_dsp_rtcd_defs.pl @@ -780,10 +780,10 @@ if (vpx_config("CONFIG_VP9_ENCODER") eq "yes") { } # CONFIG_VP9_ENCODER add_proto qw/unsigned int vpx_sad64x64_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad64x64_avg avx2 msa sse2 vsx/; +specialize qw/vpx_sad64x64_avg neon avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad64x32_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; -specialize qw/vpx_sad64x32_avg avx2 msa sse2 vsx/; +specialize qw/vpx_sad64x32_avg neon avx2 msa sse2 vsx/; add_proto qw/unsigned int vpx_sad32x64_avg/, "const uint8_t *src_ptr, int src_stride, const uint8_t *ref_ptr, int ref_stride, const uint8_t *second_pred"; specialize qw/vpx_sad32x64_avg neon avx2 msa sse2 vsx/;