From df9ce12259a4e866feeb580d2e0cf9648f60d3b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Bostr=C3=B6m?= Date: Mon, 28 Aug 2017 16:23:16 -0700 Subject: [PATCH] Re-enable disabled tests under TSan. These tests point to an already-fixed bug, this should no longer have a data race. BUG=webm:1049 Change-Id: Iaedc5db8df99362bdc501b70ff7fdebf8756fdb8 --- test/datarate_test.cc | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/datarate_test.cc b/test/datarate_test.cc index 8e93de6b9..a88f786c1 100644 --- a/test/datarate_test.cc +++ b/test/datarate_test.cc @@ -258,14 +258,6 @@ TEST_P(DatarateTestLarge, ChangingDropFrameThresh) { } } -// Disabled for tsan, see: -// https://bugs.chromium.org/p/webm/issues/detail?id=1049 -#if defined(__has_feature) -#if __has_feature(thread_sanitizer) -#define BUILDING_WITH_TSAN -#endif -#endif -#ifndef BUILDING_WITH_TSAN TEST_P(DatarateTestLarge, DropFramesMultiThreads) { denoiser_on_ = 0; cfg_.rc_buf_initial_sz = 500; @@ -285,7 +277,6 @@ TEST_P(DatarateTestLarge, DropFramesMultiThreads) { ASSERT_LE(cfg_.rc_target_bitrate, file_datarate_ * 1.4) << " The datarate for the file missed the target!"; } -#endif // !BUILDING_WITH_TSAN class DatarateTestRealTime : public DatarateTestLarge { public: @@ -402,10 +393,6 @@ TEST_P(DatarateTestRealTime, ChangingDropFrameThresh) { } } -// Disabled for tsan, see: -// https://bugs.chromium.org/p/webm/issues/detail?id=1049 - -#ifndef BUILDING_WITH_TSAN TEST_P(DatarateTestRealTime, DropFramesMultiThreads) { denoiser_on_ = 0; cfg_.rc_buf_initial_sz = 500; @@ -426,7 +413,6 @@ TEST_P(DatarateTestRealTime, DropFramesMultiThreads) { ASSERT_LE(cfg_.rc_target_bitrate, file_datarate_ * 1.4) << " The datarate for the file missed the target!"; } -#endif TEST_P(DatarateTestRealTime, GFBoost) { denoiser_on_ = 0;