generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reset x->skip for each iteration in the RD loop.

Browse Source 
This prevents ill-defined behaviour, such as setting x->skip for a mode
that is excluded because of frame-level flags (e.g. filter selection,
compound prediction selection), then not breaking out of the RD loop
because the mode is not allowed, but keeping the flag on. Whatever mode
is iterated through next in the RD loop will then carry this flag, and
all sort of bad stuff happens, such as x->skip being set on intra pred
modes.

Change-Id: I5bec46b36e38292174acb1c564b3caf00a9b4b9a
This commit is contained in:
Ronald S. Bultje
2013-01-14 12:43:12 -08:00
parent 76ac5b3937
commit 290b83ab62
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
vp9/encoder/vp9_rdopt.c
View File

@@ -3765,8 +3765,6 @@ static void rd_pick_inter_mode(VP9_COMP *cpi, MACROBLOCK *x,
*returnintra = LLONG_MAX; *returnintra = LLONG_MAX;
x->skip = 0;
mbmi->ref_frame = INTRA_FRAME; mbmi->ref_frame = INTRA_FRAME;
/* Initialize zbin mode boost for uv costing */ /* Initialize zbin mode boost for uv costing */
@@ -3809,6 +3807,8 @@ static void rd_pick_inter_mode(VP9_COMP *cpi, MACROBLOCK *x,
rate_y = 0; rate_y = 0;
rate_uv = 0; rate_uv = 0;
x->skip = 0;
this_mode = vp9_mode_order[mode_index].mode; this_mode = vp9_mode_order[mode_index].mode;
mbmi->mode = this_mode; mbmi->mode = this_mode;
mbmi->uv_mode = DC_PRED; mbmi->uv_mode = DC_PRED;