generic-library/vpx
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Using only one scale function in scale_factors struct.

Browse Source 
Functions scale_mv_q4 and scale_mv_q3_to_q4 were almost identical except
q3->q4 conversion in scale_mv_q3_to_q4. Now q3->q4 conversion happens
directly in vp9_build_inter_predictor.

Also adding useful constants: SUBPEL_BITS and SUBPEL_MASK.

Change-Id: Ia0a6ad2ac07c45fdf95a5139ece6286c035e9639
This commit is contained in:
Dmitry Kovalev 2013-08-06 15:43:56 -07:00
parent 8725ca2ed2
commit 1c552e79bd
3 changed files with 17 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
vp9/common/vp9_blockd.h
View File

@ -185,8 +185,7 @@ struct scale_factors {
int (*scale_value_x)(int val, const struct scale_factors *scale); int (*scale_value_x)(int val, const struct scale_factors *scale);
int (*scale_value_y)(int val, const struct scale_factors *scale); int (*scale_value_y)(int val, const struct scale_factors *scale);
void (*set_scaled_offsets)(struct scale_factors *scale, int row, int col); void (*set_scaled_offsets)(struct scale_factors *scale, int row, int col);
MV32 (*scale_mv_q3_to_q4)(const MV *mv, const struct scale_factors *scale); MV32 (*scale_mv)(const MV *mv, const struct scale_factors *scale);
MV32 (*scale_mv_q4)(const MV *mv, const struct scale_factors *scale);
convolve_fn_t predict[2][2][2]; // horiz, vert, avg convolve_fn_t predict[2][2][2]; // horiz, vert, avg
}; };

4
vp9/common/vp9_filter.h
View File

@ -19,7 +19,9 @@
#define VP9_FILTER_WEIGHT 128 #define VP9_FILTER_WEIGHT 128
#define VP9_FILTER_SHIFT 7 #define VP9_FILTER_SHIFT 7
#define SUBPEL_SHIFTS 16 #define SUBPEL_BITS 4
#define SUBPEL_MASK ((1 << SUBPEL_BITS) - 1)
#define SUBPEL_SHIFTS (1 << SUBPEL_BITS)
extern const int16_t vp9_bilinear_filters[SUBPEL_SHIFTS][8]; extern const int16_t vp9_bilinear_filters[SUBPEL_SHIFTS][8];
extern const int16_t vp9_sub_pel_filters_6[SUBPEL_SHIFTS][8]; extern const int16_t vp9_sub_pel_filters_6[SUBPEL_SHIFTS][8];

47
vp9/common/vp9_reconinter.c
View File

@ -33,27 +33,7 @@ static int unscaled_value(int val, const struct scale_factors *scale) {
return val; return val;
} }
static MV32 mv_q3_to_q4_with_scaling(const MV *mv, static MV32 mv_with_scaling(const MV *mv,
const struct scale_factors *scale) {
const MV32 res = {
((mv->row << 1) * scale->y_scale_fp >> VP9_REF_SCALE_SHIFT)
+ scale->y_offset_q4,
((mv->col << 1) * scale->x_scale_fp >> VP9_REF_SCALE_SHIFT)
+ scale->x_offset_q4
};
return res;
}
static MV32 mv_q3_to_q4_without_scaling(const MV *mv,
const struct scale_factors *scale) {
const MV32 res = {
mv->row << 1,
mv->col << 1
};
return res;
}
static MV32 mv_q4_with_scaling(const MV *mv,
const struct scale_factors *scale) { const struct scale_factors *scale) {
const MV32 res = { const MV32 res = {
(mv->row * scale->y_scale_fp >> VP9_REF_SCALE_SHIFT) + scale->y_offset_q4, (mv->row * scale->y_scale_fp >> VP9_REF_SCALE_SHIFT) + scale->y_offset_q4,
@ -62,8 +42,8 @@ static MV32 mv_q4_with_scaling(const MV *mv,
return res; return res;
} }
static MV32 mv_q4_without_scaling(const MV *mv, static MV32 mv_without_scaling(const MV *mv,
const struct scale_factors *scale) { const struct scale_factors *scale) {
const MV32 res = { const MV32 res = {
mv->row, mv->row,
mv->col mv->col
@ -109,14 +89,12 @@ void vp9_setup_scale_factors_for_frame(struct scale_factors *scale,
scale->scale_value_x = unscaled_value; scale->scale_value_x = unscaled_value;
scale->scale_value_y = unscaled_value; scale->scale_value_y = unscaled_value;
scale->set_scaled_offsets = set_offsets_without_scaling; scale->set_scaled_offsets = set_offsets_without_scaling;
scale->scale_mv_q3_to_q4 = mv_q3_to_q4_without_scaling; scale->scale_mv = mv_without_scaling;
scale->scale_mv_q4 = mv_q4_without_scaling;
} else { } else {
scale->scale_value_x = scale_value_x_with_scaling; scale->scale_value_x = scale_value_x_with_scaling;
scale->scale_value_y = scale_value_y_with_scaling; scale->scale_value_y = scale_value_y_with_scaling;
scale->set_scaled_offsets = set_offsets_with_scaling; scale->set_scaled_offsets = set_offsets_with_scaling;
scale->scale_mv_q3_to_q4 = mv_q3_to_q4_with_scaling; scale->scale_mv = mv_with_scaling;
scale->scale_mv_q4 = mv_q4_with_scaling;
} }
// TODO(agrange): Investigate the best choice of functions to use here // TODO(agrange): Investigate the best choice of functions to use here
@ -202,14 +180,15 @@ void vp9_build_inter_predictor(const uint8_t *src, int src_stride,
int w, int h, int weight, int w, int h, int weight,
const struct subpix_fn_table *subpix, const struct subpix_fn_table *subpix,
enum mv_precision precision) { enum mv_precision precision) {
const MV32 mv = precision == MV_PRECISION_Q4 const int is_q4 = precision == MV_PRECISION_Q4;
? scale->scale_mv_q4(src_mv, scale) const MV mv_q4 = { is_q4 ? src_mv->row : src_mv->row << 1,
: scale->scale_mv_q3_to_q4(src_mv, scale); is_q4 ? src_mv->col : src_mv->col << 1 };
const int subpel_x = mv.col & 15; const MV32 mv = scale->scale_mv(&mv_q4, scale);
const int subpel_y = mv.row & 15; const int subpel_x = mv.col & SUBPEL_MASK;
const int subpel_y = mv.row & SUBPEL_MASK;
src += (mv.row >> 4) * src_stride + (mv.col >> 4); src += (mv.row >> SUBPEL_BITS) * src_stride + (mv.col >> SUBPEL_BITS);
scale->predict[!!subpel_x][!!subpel_y][weight]( scale->predict[subpel_x != 0][subpel_y != 0][weight](
src, src_stride, dst, dst_stride, src, src_stride, dst, dst_stride,
subpix->filter_x[subpel_x], scale->x_step_q4, subpix->filter_x[subpel_x], scale->x_step_q4,
subpix->filter_y[subpel_y], scale->y_step_q4, subpix->filter_y[subpel_y], scale->y_step_q4,