From f8a5ab52571ab86032bae6e9152cd5edd0f94373 Mon Sep 17 00:00:00 2001 From: James Zern Date: Thu, 10 Sep 2015 21:04:39 -0700 Subject: [PATCH 1/2] vp9_thread_test: add non-frame-parallel files these have been supported in tile-threaded decoding since: b3b7645 vp9_dthread: remove frame_parallel_decoding_mode requirement Change-Id: Ia5a752db9be937153cf4830d9258752136356d1b --- test/vp9_thread_test.cc | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/test/vp9_thread_test.cc b/test/vp9_thread_test.cc index 233e1b1a9..17b72d5e9 100644 --- a/test/vp9_thread_test.cc +++ b/test/vp9_thread_test.cc @@ -190,7 +190,7 @@ string DecodeFile(const string& filename, int num_threads) { void DecodeFiles(const FileList files[]) { for (const FileList *iter = files; iter->name != NULL; ++iter) { SCOPED_TRACE(iter->name); - for (int t = 2; t <= 8; ++t) { + for (int t = 1; t <= 8; ++t) { EXPECT_EQ(iter->expected_md5, DecodeFile(iter->name, t)) << "threads = " << t; } @@ -307,6 +307,19 @@ TEST(VP9DecodeMultiThreadedTest, Decode3) { DecodeFiles(files); } + +TEST(VP9DecodeMultiThreadedTest, Decode4) { + static const FileList files[] = { + { "vp90-2-08-tile_1x2.webm", "570b4a5d5a70d58b5359671668328a16" }, + { "vp90-2-08-tile_1x4.webm", "988d86049e884c66909d2d163a09841a" }, + { "vp90-2-08-tile_1x8.webm", "0941902a52e9092cb010905eab16364c" }, + { "vp90-2-08-tile-4x1.webm", "06505aade6647c583c8e00a2f582266f" }, + { "vp90-2-08-tile-4x4.webm", "85c2299892460d76e2c600502d52bfe2" }, + { NULL, NULL } + }; + + DecodeFiles(files); +} #endif // CONFIG_WEBM_IO INSTANTIATE_TEST_CASE_P(Synchronous, VPxWorkerThreadTest, ::testing::Bool()); From 078312979ed8d90f62571bf5a664810632d1b612 Mon Sep 17 00:00:00 2001 From: James Zern Date: Thu, 10 Sep 2015 21:08:46 -0700 Subject: [PATCH 2/2] vp9_thread_test: clarify test case names rename Decode[2-4] to something more precise Change-Id: I68c4f189796eb11ac1a5b7b682f24efb71708187 --- test/vp9_thread_test.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/test/vp9_thread_test.cc b/test/vp9_thread_test.cc index 17b72d5e9..92e4b9688 100644 --- a/test/vp9_thread_test.cc +++ b/test/vp9_thread_test.cc @@ -235,13 +235,13 @@ TEST(VPxWorkerThreadTest, TestSerialInterface) { EXPECT_EQ(expected_md5, DecodeFile(filename, 2)); } -TEST(VP9DecodeMultiThreadedTest, Decode) { +TEST(VP9DecodeMultiThreadedTest, NoTilesNonFrameParallel) { // no tiles or frame parallel; this exercises loop filter threading. EXPECT_EQ("b35a1b707b28e82be025d960aba039bc", DecodeFile("vp90-2-03-size-226x226.webm", 2)); } -TEST(VP9DecodeMultiThreadedTest, Decode2) { +TEST(VP9DecodeMultiThreadedTest, FrameParallel) { static const FileList files[] = { { "vp90-2-08-tile_1x2_frame_parallel.webm", "68ede6abd66bae0a2edf2eb9232241b6" }, @@ -255,8 +255,7 @@ TEST(VP9DecodeMultiThreadedTest, Decode2) { DecodeFiles(files); } -// Test tile quantity changes within one file. -TEST(VP9DecodeMultiThreadedTest, Decode3) { +TEST(VP9DecodeMultiThreadedTest, FrameParallelResize) { static const FileList files[] = { { "vp90-2-14-resize-fp-tiles-1-16.webm", "0cd5e632c326297e975f38949c31ea94" }, @@ -308,7 +307,7 @@ TEST(VP9DecodeMultiThreadedTest, Decode3) { DecodeFiles(files); } -TEST(VP9DecodeMultiThreadedTest, Decode4) { +TEST(VP9DecodeMultiThreadedTest, NonFrameParallel) { static const FileList files[] = { { "vp90-2-08-tile_1x2.webm", "570b4a5d5a70d58b5359671668328a16" }, { "vp90-2-08-tile_1x4.webm", "988d86049e884c66909d2d163a09841a" },