generic-library/valijson
1
0
Fork 0
mirror of https://github.com/tristanpenman/valijson.git synced 2025-03-03 12:58:03 +01:00
Code Issues Projects Releases Wiki Activity

Push oneOf constraint error only when validation fails actually

Browse Source
This commit is contained in:
Hiroyuki Kobayashi 2015-07-06 22:52:55 +09:00
parent 7c4d935f4c
commit 04ff1dec15
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
include/valijson/validation_visitor.hpp
View File

@ -755,14 +755,26 @@ public:
virtual bool visit(const OneOfConstraint &constraint)
{
unsigned int numValidated = 0;
ValidationResults newResults;
ValidationResults *childResults = (results) ? &newResults : NULL;
BOOST_FOREACH( const Schema &schema, constraint.schemas ) {
if (validateSchema(schema)) {
ValidationVisitor<AdapterType> v(target, context, strictTypes, childResults);
if (v.validateSchema(schema)) {
numValidated++;
}
}
if (numValidated != 1) {
if (numValidated == 0) {
if (results) {
ValidationResults::Error childError;
while (childResults->popError(childError)) {
results->pushError(childError.context, childError.description);
}
results->pushError(context, "Failed to validate against any child schemas allowed by oneOf constraint.");
}
return false;
} else if (numValidated != 1) {
if (results) {
results->pushError(context, "Failed to validate against exactly one child schema.");
}