generic-library/ssh2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

_libssh2_ntohu64: fix conversion from network bytes to uint64

Browse Source 
Cast individual bytes to uint64 to avoid overflow in arithmetic.
This commit is contained in:
Joey Degges 2010-12-21 02:53:20 -08:00 committed by Peter Stuge
parent 20da09932e
commit fd691deb17
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/misc.c
View File

@ -156,8 +156,10 @@ _libssh2_ntohu64(const unsigned char *buf)
{ {
unsigned long msl, lsl; unsigned long msl, lsl;
msl = (buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3]; msl = ((libssh2_uint64_t)buf[0] << 24) | ((libssh2_uint64_t)buf[1] << 16)
lsl = (buf[4] << 24) | (buf[5] << 16) | (buf[6] << 8) | buf[7]; | ((libssh2_uint64_t)buf[2] << 8) | (libssh2_uint64_t)buf[3];
lsl = ((libssh2_uint64_t)buf[4] << 24) | ((libssh2_uint64_t)buf[5] << 16)
| ((libssh2_uint64_t)buf[6] << 8) | (libssh2_uint64_t)buf[7];
return ((libssh2_uint64_t)msl <<32) | lsl; return ((libssh2_uint64_t)msl <<32) | lsl;
} }