generic-library/ssh2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

_libssh2_packet_add: turn ifs into a single switch

Browse Source
This commit is contained in:
Daniel Stenberg 2010-11-10 12:21:48 +01:00
parent a302428335
commit fb6afd01a1
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/packet.c
View File

@ -461,16 +461,19 @@ _libssh2_packet_add(LIBSSH2_SESSION * session, unsigned char *data,
* I know this is very ugly and not a really good use of "goto", but * I know this is very ugly and not a really good use of "goto", but
* this case statement would be even uglier to do it any other way * this case statement would be even uglier to do it any other way
*/ */
if (session->packAdd_state == libssh2_NB_state_jump1) { switch(session->packAdd_state) {
case libssh2_NB_state_jump1:
goto libssh2_packet_add_jump_point1; goto libssh2_packet_add_jump_point1;
} else if (session->packAdd_state == libssh2_NB_state_jump2) { case libssh2_NB_state_jump2:
goto libssh2_packet_add_jump_point2; goto libssh2_packet_add_jump_point2;
} else if (session->packAdd_state == libssh2_NB_state_jump3) { case libssh2_NB_state_jump3:
goto libssh2_packet_add_jump_point3; goto libssh2_packet_add_jump_point3;
} else if (session->packAdd_state == libssh2_NB_state_jump4) { case libssh2_NB_state_jump4:
goto libssh2_packet_add_jump_point4; goto libssh2_packet_add_jump_point4;
} else if (session->packAdd_state == libssh2_NB_state_jump5) { case libssh2_NB_state_jump5:
goto libssh2_packet_add_jump_point5; goto libssh2_packet_add_jump_point5;
default: /* nothing to do */
break;
} }
/* FIXME: I've noticed that DATA is accessed without proper /* FIXME: I've noticed that DATA is accessed without proper