generic-library/ssh2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wincng.c: fixed possible memory leak in _libssh2_wincng_hash

Browse Source 
If _libssh2_wincng_hash_update failed _libssh2_wincng_hash_final
would never have been called before.

Reported by Zenju.
This commit is contained in:
Marc Hoersken 2015-12-22 13:36:56 +01:00
parent 9bf32da607
commit d0ffeba72e
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/wincng.c
View File

@ -415,16 +415,15 @@ _libssh2_wincng_hash(unsigned char *data, unsigned long datalen,
unsigned char *hash, unsigned long hashlen)
{
_libssh2_wincng_hash_ctx ctx;
int ret;
if (!_libssh2_wincng_hash_init(&ctx, hAlg, hashlen, NULL, 0)) {
if (!_libssh2_wincng_hash_update(&ctx, data, datalen)) {
if (!_libssh2_wincng_hash_final(&ctx, hash)) {
return 0;
}
}
ret = _libssh2_wincng_hash_init(&ctx, hAlg, hashlen, NULL, 0);
if (!ret) {
ret = _libssh2_wincng_hash_update(&ctx, data, datalen);
ret |= _libssh2_wincng_hash_final(&ctx, hash);
}
return -1;
return ret;
}