generic-library/ssh2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wincng.c: explicitly ignore BCrypt*AlgorithmProvider return codes

Browse Source 
Fixes VS2012 code analysis warning C6031:
return value ignored: <function> could return unexpected value
This commit is contained in:
Marc Hoersken 2014-12-15 00:45:51 +01:00
parent f31c9fb221
commit c0bface8a7
1 changed files with 29 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/wincng.c
View File

@ -199,25 +199,25 @@ _libssh2_wincng_init(void)
{ {
int ret; int ret;
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgRNG, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgRNG,
BCRYPT_RNG_ALGORITHM, NULL, 0); BCRYPT_RNG_ALGORITHM, NULL, 0);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHashMD5, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHashMD5,
BCRYPT_MD5_ALGORITHM, NULL, 0); BCRYPT_MD5_ALGORITHM, NULL, 0);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHashSHA1, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHashSHA1,
BCRYPT_SHA1_ALGORITHM, NULL, 0); BCRYPT_SHA1_ALGORITHM, NULL, 0);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHmacMD5, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHmacMD5,
BCRYPT_MD5_ALGORITHM, NULL, BCRYPT_MD5_ALGORITHM, NULL,
BCRYPT_ALG_HANDLE_HMAC_FLAG); BCRYPT_ALG_HANDLE_HMAC_FLAG);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHmacSHA1, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgHmacSHA1,
BCRYPT_SHA1_ALGORITHM, NULL, BCRYPT_SHA1_ALGORITHM, NULL,
BCRYPT_ALG_HANDLE_HMAC_FLAG); BCRYPT_ALG_HANDLE_HMAC_FLAG);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgRSA, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgRSA,
BCRYPT_RSA_ALGORITHM, NULL, 0); BCRYPT_RSA_ALGORITHM, NULL, 0);
BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgDSA, (void)BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgDSA,
BCRYPT_DSA_ALGORITHM, NULL, 0); BCRYPT_DSA_ALGORITHM, NULL, 0);
ret = BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgAES_CBC, ret = BCryptOpenAlgorithmProvider(&_libssh2_wincng.hAlgAES_CBC,
BCRYPT_AES_ALGORITHM, NULL, 0); BCRYPT_AES_ALGORITHM, NULL, 0);
@ -226,7 +226,7 @@ _libssh2_wincng_init(void)
(PBYTE)BCRYPT_CHAIN_MODE_CBC, (PBYTE)BCRYPT_CHAIN_MODE_CBC,
sizeof(BCRYPT_CHAIN_MODE_CBC), 0); sizeof(BCRYPT_CHAIN_MODE_CBC), 0);
if (!BCRYPT_SUCCESS(ret)) { if (!BCRYPT_SUCCESS(ret)) {
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgAES_CBC, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgAES_CBC, 0);
} }
} }
@ -237,7 +237,7 @@ _libssh2_wincng_init(void)
(PBYTE)BCRYPT_CHAIN_MODE_NA, (PBYTE)BCRYPT_CHAIN_MODE_NA,
sizeof(BCRYPT_CHAIN_MODE_NA), 0); sizeof(BCRYPT_CHAIN_MODE_NA), 0);
if (!BCRYPT_SUCCESS(ret)) { if (!BCRYPT_SUCCESS(ret)) {
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRC4_NA, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRC4_NA, 0);
} }
} }
@ -248,7 +248,7 @@ _libssh2_wincng_init(void)
(PBYTE)BCRYPT_CHAIN_MODE_CBC, (PBYTE)BCRYPT_CHAIN_MODE_CBC,
sizeof(BCRYPT_CHAIN_MODE_CBC), 0); sizeof(BCRYPT_CHAIN_MODE_CBC), 0);
if (!BCRYPT_SUCCESS(ret)) { if (!BCRYPT_SUCCESS(ret)) {
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlg3DES_CBC, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlg3DES_CBC, 0);
} }
} }
} }
@ -256,16 +256,16 @@ _libssh2_wincng_init(void)
void void
_libssh2_wincng_free(void) _libssh2_wincng_free(void)
{ {
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRNG, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRNG, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHashMD5, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHashMD5, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHashSHA1, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHashSHA1, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHmacMD5, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHmacMD5, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHmacSHA1, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgHmacSHA1, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRSA, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRSA, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgDSA, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgDSA, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgAES_CBC, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgAES_CBC, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRC4_NA, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlgRC4_NA, 0);
BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlg3DES_CBC, 0); (void)BCryptCloseAlgorithmProvider(_libssh2_wincng.hAlg3DES_CBC, 0);
memset(&_libssh2_wincng, 0, sizeof(_libssh2_wincng)); memset(&_libssh2_wincng, 0, sizeof(_libssh2_wincng));
} }