generic-library/ssh2
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hostkey.c: fix invalid memory access if libssh2_dsa_new fails

Browse Source 
Reported by dimmaq, fixes #66
This commit is contained in:
Marc Hoersken 2015-12-06 21:30:01 +01:00
parent 51dcded3eb
commit 036196b0b0
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hostkey.c
View File

@ -274,6 +274,8 @@ hostkey_method_ssh_dss_init(LIBSSH2_SESSION * session,
libssh2_dsa_ctx *dsactx; libssh2_dsa_ctx *dsactx;
const unsigned char *p, *q, *g, *y, *s; const unsigned char *p, *q, *g, *y, *s;
unsigned long p_len, q_len, g_len, y_len, len; unsigned long p_len, q_len, g_len, y_len, len;
int ret;
(void) hostkey_data_len; (void) hostkey_data_len;
if (*abstract) { if (*abstract) {
@ -306,7 +308,11 @@ hostkey_method_ssh_dss_init(LIBSSH2_SESSION * session,
y = s; y = s;
/* s += y_len; */ /* s += y_len; */
_libssh2_dsa_new(&dsactx, p, p_len, q, q_len, g, g_len, y, y_len, NULL, 0); ret = _libssh2_dsa_new(&dsactx, p, p_len, q, q_len,
g, g_len, y, y_len, NULL, 0);
if (ret) {
return -1;
}
*abstract = dsactx; *abstract = dsactx;