generic-library/squirrel
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Never assume the format is actually a string.

Browse Source 
The invoker should at least know that the value he specified is not of the correct type.
This commit is contained in:
Sandu Liviu Catalin 2016-11-16 10:47:29 +02:00 committed by GitHub
parent fae1cabb51
commit 795af921cc
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sqstdlib/sqstdstring.cpp
View File

@ -69,7 +69,10 @@ SQRESULT sqstd_format(HSQUIRRELVM v,SQInteger nformatstringidx,SQInteger *outlen
const SQChar *format;
SQChar *dest;
SQChar fmt[MAX_FORMAT_LEN];
sq_getstring(v,nformatstringidx,&format);
const SQRESULT res = sq_getstring(v,nformatstringidx,&format);
if (SQ_FAILED(res)) {
return res; // propagate the error
}
SQInteger format_size = sq_getsize(v,nformatstringidx);
SQInteger allocated = (format_size+2)*sizeof(SQChar);
dest = sq_getscratchpad(v,allocated);