generic-library/rapidjson
1
0
Fork 0
mirror of https://github.com/Tencent/rapidjson.git synced 2025-10-27 11:06:53 +01:00
Code Issues Projects Releases Wiki Activity

Fix ambiguous cases in Pointer::Create()

Browse Source
This commit is contained in:
miloyip
2015-05-04 15:02:43 +08:00
parent b6a54f7244
commit 436625f83c
2 changed files with 46 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
test/unittest/pointertest.cpp
View File

@@ -532,9 +532,13 @@ TEST(Pointer, Create) {
Value* v = &Pointer("/foo/-").Create(d, d.GetAllocator());
EXPECT_EQ(&d["foo"][1], v);
}
{
Value* v = &Pointer("/foo/-/-").Create(d, d.GetAllocator());
EXPECT_EQ(&d["foo"][2][0], v);
// "foo/-" is a newly created null value x.
// "foo/-/-" finds that x is not an array, it converts x to empty object
// and treats - as "-" member name
EXPECT_EQ(&d["foo"][2]["-"], v);
}
{
@@ -1314,3 +1318,22 @@ TEST(Pointer, SwapValueByPointer_NoAllocator) {
EXPECT_STREQ("bar", d["foo"][0].GetString());
EXPECT_STREQ("baz", d["foo"][1].GetString());
}
TEST(Pointer, Ambiguity) {
{
Document d;
d.Parse("{\"0\" : [123]}");
EXPECT_EQ(123, Pointer("/0/0").Get(d)->GetInt());
Pointer("/0/a").Set(d, 456); // Change array [123] to object {456}
EXPECT_EQ(456, Pointer("/0/a").Get(d)->GetInt());
}
{
Document d;
EXPECT_FALSE(d.Parse("[{\"0\": 123}]").HasParseError());
EXPECT_EQ(123, Pointer("/0/0").Get(d)->GetInt());
Pointer("/0/1").Set(d, 456); // 1 is treated as "1" to index object
EXPECT_EQ(123, Pointer("/0/0").Get(d)->GetInt());
EXPECT_EQ(456, Pointer("/0/1").Get(d)->GetInt());
}
}